Make coverage support incremental compilation #24773
Open
+165
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for working on this. Let me know when this is ready! Seems like github actions are having a tough day though, so we'll need to rerun some jobs. |
Contributor
Author
I want to port the tests as well, but I'm having trouble running the tests. I get: |
Contributor
|
I think for coverage it should be |
Contributor
Author
|
@tgodzik Thank you. I needed to cleanup my workspace directory since I had last compiled Scala3 a long time ago and something was broken in the |
lolgab
force-pushed
the
incremental-coverage
branch
from
a3f67fd to
6ac0a8f
Compare
lolgab
force-pushed
the
incremental-coverage
branch
from
6ac0a8f to
2017109
Compare
Contributor
Author
|
@tgodzik I'm ready for review |
In capture checking, a type mismatch might happen for a synthesized tree (say from implicit search). It can be helpful to show this tree. Before capture checking a helpful message is less likely since we don't synthesize implicit trees that then don't match under the standard typing rules.
Fields are only allowed in stateful classes unless marked with @untrackedCaptures.
Co-authored-by: Oliver Bračevac <bracevac@users.noreply.github.com>
Previously, method type parameters were always renamed if they had the same name as any class type parameter, regardless of whether the class type parameter was actually used in the method signature. As a result, we rename methods's type params for unnecessary names like: scala#24671 (Note that renaming actually doesn't cause binary incompatibility, and this change is just for make generic signature a bit clear and silence false-positive MIMA reporting). For example, in an example below, the Scala compiler rename the generic signature of `bar` to something like `bar[T1](x: T1): T1` because `T` is used by `Foo[T]`. However, this is unnessary rename because none of T in method signature refer the `T` of `Foo[T]`. ```scala class Foo[T]: def bar[T](x: T): T = ??? ``` This commit makes the renaming conditional: Method type parameters are only renamed when - (1) A class type parameter is referenced in the method signature, and - (2) That class type parameter is shadowed by a method type parameter
Co-authored-by: Lukas Rytz <lukas.rytz@gmail.com>
Move isTypeParameterInMethSig as a local function and simplify it: collecting method type parameters by checking owner directly instead of searching the initialSymbol's typeParams list.
Add test cases for nested class generic signatures when method type parameters shadow enclosing class type parameters. The tests verify that Scala 3 correctly handles type parameter name conflicts in nested generic classes by renaming method-level type parameters to avoid clashing with outer class type parameters. Closes scala#24619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of scoverage/scalac-scoverage-plugin#742 for Scala 3.