Skip to content

Add/clarify comments for ExprType and TypeVar #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odersky merged 2 commits into from
Jan 15, 2015
Merged

Add/clarify comments for ExprType and TypeVar #333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01e1932
clarify comment about TypeVar
olhotak Jan 14, 2015
1815894
add comment for ExprType
olhotak Jan 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/dotty/tools/dotc/core/Types.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2040,6 +2040,7 @@ object Types {
unique(new ImplicitMethodType(paramNames, paramTypes)(resultTypeExp))
}

/** A by-name parameter type of the form `=> T`, or the type of a method with no parameter list. */
abstract case class ExprType(override val resultType: Type)
extends CachedProxyType with TermType with MethodicType {
override def underlying(implicit ctx: Context): Type = resultType
Expand Down Expand Up @@ -2184,13 +2185,16 @@ object Types {

// ------------ Type variables ----------------------------------------

/** A type variable is essentially a switch that models some part of a substitution.
/** In a TypeApply tree, a TypeVar is created for each argument type to be inferred.
* Every type variable is referred to by exactly one inferred type parameter of some
* TypeApply tree.
*
* A type variable is essentially a switch that models some part of a substitution.
* It is first linked to `origin`, a poly param that's in the current constraint set.
* It can then be (once) instantiated to some other type. The instantiation is
* recorded in the type variable itself, or else, if the current type state
* is different from the variable's creation state (meaning unrolls are possible)
* in the current typer state. Every type variable is referred to by exactly
* one inferred type parameter in a TypeApply tree.
* in the current typer state.
*
* @param origin The parameter that's tracked by the type variable.
* @param creatorState The typer state in which the variable was created.
Expand Down