Skip to content

Fix #3337 - Repl CompanionObject #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarter merged 1 commit into from
Oct 26, 2017
Merged

Fix #3337 - Repl CompanionObject #3369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/interactive/Interactive.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ object Interactive {
/** Filter for names that should appear when looking for completions. */
private[this] object completionsFilter extends NameFilter {
def apply(pre: Type, name: Name)(implicit ctx: Context): Boolean =
!name.isConstructorName && name.is(SimpleNameKind)
!name.isConstructorName && name.toTermName.info.kind == SimpleNameKind
}

/** Find named trees with a non-empty position whose symbol match `sym` in `trees`.
Expand Down
6 changes: 6 additions & 0 deletions compiler/test/dotty/tools/repl/TabcompleteTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ class TabcompleteTests extends ReplTest {
comp.suggestions.sorted == List("slice", "sliding"))
}

@Test def tabCompleteModule: Unit =
fromInitialState{ implicit s =>
val comp = tabComplete("scala.Pred")
assertEquals(comp.suggestions,List("Predef"))
}

@Test def autoCompleteValAssign: Unit =
fromInitialState { implicit s => tabComplete("val x = 5") }

Expand Down