Backend discovered issues #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hodType ExprType erases to MethodType and need to be handled.
This info transformation was left untriggered before backend was enabled.
…(requested by backend)
DarkDimius
force-pushed
the
backend-backports
branch
from
bbd2d9c to
5027f01
Compare
Contributor
|
The first 4 commits LGTM. I have some concerns regarding the last one. Period creation looks like a hotspot - we should verify that these asserts are not going to slow us down (even (say) 0.2% slowdown is too much for this!). I am raising this because I found it very easy to diagnose what went wrong even without the asserts. I added a phase and immediately got weird errors about phases everywhere. Maybe a more global criterion like count the installed phases in Compiler? |
Contributor
Author
|
@odersky please have a look on new commit. |
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Apr 29, 2025
Backport "Check for tasty error in template trees." to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #349, fix #348, assert for overflows in periods. Disable tests that fail late in backend due to other phases.
@odersky please review.