Fix #4044: Change quote pickled representation #4081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
test performance please |
Member
|
performance test scheduled: 1 job(s) in queue, 0 running. |
nicolasstucki
changed the title
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4081/ to see the changes. Benchmarks is based on merging with master (bdfe740) |
nicolasstucki
force-pushed
the
fix-#4044
branch
6 times, most recently
from
0892ce9 to
2e52a0c
Compare
Closed
Merged
biboudis
reviewed
Mar 14, 2018
| if (inQuote) { | ||
| val (body1, quotes) = nested(isQuote = false).split(body) | ||
| makeHole(body1, quotes, splice.tpe) | ||
| private def splice(splice: Select)(implicit ctx: Context): Tree = { |
Contributor
There was a problem hiding this comment.
splice could handle the case of a TypeTree before. 🤔
odersky
approved these changes
Mar 15, 2018
| def tryHeal(tp: Type, pos: Position)(implicit ctx: Context): Option[String] = tp match { | ||
| case tp: TypeRef => | ||
| if (level == 0) { | ||
| assert(ctx.owner.is(Macro)) |
Contributor
There was a problem hiding this comment.
Why was the assert dropped?
Contributor
Author
There was a problem hiding this comment.
In one case where the macro contained an anonymous function inside and the tryHeal saw that function as ctx.owner. Now the assert is
assert(ctx.owner.ownersIterator.exists(_.is(Macro)))| } | ||
| } | ||
|
|
||
| /** Transforms the contents of a splice nested |
Contributor
There was a problem hiding this comment.
"splice nested" -> "nested splice"?
| * val y = ??? | ||
| * { ... '{ ... x .. y ... } ... }.unary_~ | ||
| * } | ||
| * |
Contributor
There was a problem hiding this comment.
Add: "Then the spliced subexpression"
nicolasstucki
force-pushed
the
fix-#4044
branch
from
654eb71 to
b74c723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.