Avoid spurious "double-def" error message involving erroneous definition #4141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Specifically, it fixes tests/neg/i4058.scala which is the file mentioned in http://dotty-ci.epfl.ch/lampepfl/dotty/3814/6 and which is affected by ad002ff (the commit which introduced the issue). |
Contributor
Author
|
BTW this suggests a deeper issue: already in #4064 we had seen that turning string errors into proper errors affected errors counts. |
This was referenced Mar 19, 2018
smarter
approved these changes
Mar 19, 2018
Contributor
Author
|
Self-merging since this appears to indeed fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this fixes master's failure.