Test reporting should consistently count and report test failures, not compiler errors #4383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
approved these changes
May 1, 2018
Right now we report the number of "errors", that is compiler errors including the expected ones, but we should instead use the test "failures", that is the unexpected behaviors. Also make errorCount private.
This small issue swaps labels in the error output and complicated fixing failures.
We can't use `_failures.size` since it's a Set. Using a `Seq` for now would be pointless, since most elements are just `Generic` failures, but would have a point if we wanted to show info on those failures in the final log.
This output refers to the number of CompilationTest instances with failures.
Blaisorblade
force-pushed
the
test-replace-errors-by-failures
branch
from
033f85b to
4300c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While individual tests should compare actual and expected numbers of errors, the overall reporting is meant to report failures.
Discovered while investigating the root cause of #4379 (where problems arose from a similar confusion) — so the PR is built on top of that (and intended to be merged separately).