Worksheet improvements #5230
Merged
Worksheet improvements #5230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the use of strings for identifying messages by types (WorksheetExecRequest and WorksheetPublishOutputNotification). Also contains some light cleanup/uniformization
Duhemm
reviewed
Oct 10, 2018
Contributor
Duhemm
left a comment
Duhemm
left a comment
There was a problem hiding this comment.
That's indeed a lot cleaner 👍
- Only enable worksheet features on the client if the server supports them using the LSP support for dynamic feature registration. - Replace the global functions and state in worksheet.ts by a WorksheetProvider class, move some of the global functions specific to one worksheet into Worksheet
We used interchangeably the term "run", "evaluate" and "exec" for talking about running a worksheet. This commit does a lot of renaming to standardize on using "run" everywhere.
smarter
force-pushed
the
worksheet-stuff
branch
from
50ce4a0 to
59ceea9
Compare
Member
Author
|
Going to merge this as-is and open another PR for further improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.