Error Messages: Refactor backticks, capitalize messages #5335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Oct 30, 2018
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
Contributor
Author
|
Waiting on tests to perform on CI so I can fix any broken, since on my machine I can't compile the |
Fix test resources by making them be like the result from messages Remove backticks from 1379
Contributor
Author
|
Tests fixed! |
Contributor
|
@sleepiejohn could you rebase your PR the changes so far look good. |
compiler/test-resources/repl/errmsgs
Outdated
| | found: Int(1) | ||
| | required: String | ||
| | Found: Int(1) | ||
| | Required: Stri |
Contributor
There was a problem hiding this comment.
You removed part of String by mistake here.
Contributor
Author
There was a problem hiding this comment.
Oh dang, my bad!
Contributor
Author
|
Seems that language server tests are now included and it's currently broke because of capitalization, I'll tend to it later today |
Fix LS diagnostics tests
nicolasstucki
approved these changes
Dec 12, 2018
Contributor
|
Thanks @sleepiejohn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary backticks ` from messages and explanations, around interpolations and from text, wraping those texts into interpolations so it can be picked by the highlighter
`()`becomes${"()"}`$mySymbol`becomes$mySymbolAlso capitalizes messages, but:
matchwere not capitalized.value,class,objectwere not capitalized.This all to remove clutter and increase experience when sending those errors to editors for example, and dont let newcomers be confused since
`is part of the language when used in a case expression and to escape keywordsPart of #1589