Tailrec improvements #5399
Merged
Tailrec improvements #5399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
force-pushed
the
fix-5163-bis
branch
from
edcbf99 to
ff730ca
Compare
sjrd
requested changes
Nov 6, 2018
compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala
Outdated
Show resolved
Hide resolved
compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala
Outdated
Show resolved
Hide resolved
allanrenucci
force-pushed
the
fix-5163-bis
branch
from
ff730ca to
089eb40
Compare
Member
|
The optimization is incorrect. It is possible to re-enter a tail-pos context even from some places where we are in a non-tail-pos context. The most important example is when finding a |
allanrenucci
force-pushed
the
fix-5163-bis
branch
5 times, most recently
from
3eca547 to
f8f2b4e
Compare
allanrenucci
changed the title
allanrenucci
force-pushed
the
fix-5163-bis
branch
from
f8f2b4e to
e823e8b
Compare
A while loop condition or body is not in tail position.
allanrenucci
force-pushed
the
fix-5163-bis
branch
from
e823e8b to
ac42ec0
Compare
sjrd
approved these changes
Nov 9, 2018
We can stop traversing a tree in Tailrec as soon as we are not in tail position anymore and we are not within a labeled block in tail position. We keep traversing the tree however if the method is @tailrec annotated to report errors on eventual recursive calls.
allanrenucci
force-pushed
the
fix-5163-bis
branch
from
ac42ec0 to
a129cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.