Add missing positions to trees created with TASTy reflect #5940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nicolasstucki
force-pushed
the
add-missing-positions-in-tasty-reflect-constructors
branch
from
53c301b to
acefb73
Compare
Merged
liufengyun
approved these changes
Feb 18, 2019
Contributor
liufengyun
left a comment
liufengyun
left a comment
There was a problem hiding this comment.
Why Context => T instead of T, given that we do not change the context.
Otherwise, LGTM
Contributor
|
Confirmed that it works for #5796. |
nicolasstucki
commented
Feb 18, 2019
Contributor
Author
nicolasstucki
left a comment
nicolasstucki
left a comment
There was a problem hiding this comment.
We change the context to ctx.withSource(rootPosition.source) in withDefaultPos
protected def withDefaultPos[T <: Tree](fn: Context => T)(implicit ctx: Context): T = {
fn(ctx.withSource(rootPosition.source)).withSpan(rootPosition.span)
}
liufengyun
deleted the
add-missing-positions-in-tasty-reflect-constructors
branch
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.