Skip to content

Ycheck that methods defined in ClassInfo exist in tree. #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
odersky merged 25 commits into from
Aug 4, 2015
Merged

Ycheck that methods defined in ClassInfo exist in tree. #735

odersky merged 25 commits into from
Aug 4, 2015

Conversation

@DarkDimius
Copy link
Contributor

@DarkDimius DarkDimius commented Jul 23, 2015

based on #693.
Known to fail: trait TreeInfo tree does not define methods: Set(method initial$MatchingArgs)

DarkDimius added 17 commits July 13, 2015 15:31
@DarkDimius
Make trees have predictable hash codes.
c76d63d 
Simplifies debugging for me.
@DarkDimius
SpecializeNames: Duplicate scalac behaviour, sort tparams
d898560
@DarkDimius
Fix ClassCastException in patmat when using Product1.
9185428
@DarkDimius
Enable 61 tests that succeed.
ef536f0
@DarkDimius
Make symbols have predictable hash codes.
04b1253
@DarkDimius
Patmat: fix sub patterns of Product-1's
91772a6
@DarkDimius
Upgrade shared backend.
5481589 
Fixes bugs in handling try-finally blocks.
@DarkDimius
Update version of shared backend.
18a034c 
Includes fix to emission of invokeDynamic instructions
in positions where expected type isn't the type of lambda being returned.
SI-9387
@DarkDimius
Remove warning from .check file that is not emitted by Dotty
843ec4f
@DarkDimius
Fixes to name comparison
10ea712 
Use x.length - y.length trick,
Names are hash-consed.
@DarkDimius
Address review comments of scala#693
9bc9578
@DarkDimius
Compile dotty.*, not only dotty.tools.
a1087a4
@DarkDimius
Add Symdenotation. isValueClassConvertMethod
5766b99 
Checks if the symbols is a synthetic symbol that is
created by values class transformation to represent
conversions between representations of a value class.
@DarkDimius
YCheck that all methods are defined in tree
31010b6
@DarkDimius
YCheck that methods, fields and variables have names that are valid o…
9d609fb 
…n JVM.
@DarkDimius
Lazy initialisers names do not get mangled.
868591c
@DarkDimius
Workaround an issue in mixin.
0261ed0 
Mixi does not define stored&substed in classes that inherit this trait.
@DarkDimius DarkDimius mentioned this pull request Jul 24, 2015
Closed
@odersky
Copy link
Contributor

odersky commented Jul 27, 2015

We now see a non-abstract method error for a lazy val in PatMat.

@DarkDimius
Fix enumeration of all members of the class
f018c38 
used a wrong member function inside,
led to errors similar to:

 java.lang.ClassFormatError: Duplicate method name&signature in class file dotty/tools/dotc/core/Types$WildcardType
@DarkDimius
Fix lazy vals in mixin
1512957 
They should not become deferred.
And there could be multiple symbols with same name in same scope, e.g.:

implicit class Foo(){}

will create implicit method Foo that and a lazy module named Foo
@DarkDimius
Workaround scala#742 and add a test for it.
a43d39a 
Making a correct fix could take some time,
and I want to find other issues before I start working on this one.
@DarkDimius
Add a test for scala#743 to pending.
e147fbe
@DarkDimius
Copy link
Contributor Author

DarkDimius commented Jul 28, 2015

With fixes from this branch, dotty compiled by dotty can print greeting without dying.
Trying to compile something fails with

java.lang.AbstractMethodError: Method dotty/tools/dotc/core/Names$TypeName.scala$collection$IndexedSeqOptimized$$super$endsWith(Lscala/collection/GenSeq;)Z is abstract
    at dotty.tools.dotc.core.Names$TypeName.scala$collection$IndexedSeqOptimized$$super$endsWith(Names.scala)
    at scala.collection.IndexedSeqOptimized$class.endsWith(IndexedSeqOptimized.scala:278)
    at dotty.tools.dotc.core.Names$Name.endsWith(Names.scala:38)
    at dotty.tools.dotc.core.NameOps$NameDecorator$.isAvoidClashName$extension(NameOps.scala:75)
    at dotty.tools.dotc.core.NameOps$NameDecorator$.stripAvoidClashSuffix$extension(NameOps.scala:145)
    at dotty.tools.dotc.core.NameOps$NameDecorator$.adjustIfModuleClass$extension(NameOps.scala:149)
    at dotty.tools.dotc.core.Symbols.newModuleSymbol(Symbols.scala:154)
    at dotty.tools.dotc.core.Symbols.newPackageSymbol(Symbols.scala:206)
    at dotty.tools.dotc.core.Definitions.RootClass(Definitions.scala:98)
    at dotty.tools.dotc.core.Denotations$DenotationsBase.recur$2(Denotations.scala:968)
    at dotty.tools.dotc.core.Denotations$DenotationsBase.staticRef(Denotations.scala:984)
    at dotty.tools.dotc.core.Symbols.requiredPackage(Symbols.scala:347)
    at dotty.tools.dotc.core.Definitions.ScalaPackageVal(Definitions.scala:110)
    at dotty.tools.dotc.core.Definitions.ScalaPackageClass(Definitions.scala:112)
    at dotty.tools.dotc.core.Definitions.AnyClass(Definitions.scala:141)
    at dotty.tools.dotc.core.Definitions.syntheticCoreClasses(Definitions.scala:625)
    at dotty.tools.dotc.core.Definitions.init(Definitions.scala:647)
    at dotty.tools.dotc.Compiler.rootContext(Compiler.scala:98)
    at dotty.tools.dotc.Compiler.newRun(Compiler.scala:125)
    at dotty.tools.dotc.Driver.doCompile(Driver.scala:20)
    at dotty.tools.dotc.Driver.process(Driver.scala:44)
    at dotty.tools.dotc.Driver.main(Driver.scala:48)
    at dotty.tools.dotc.Main.main(Main.scala)

@odersky
Copy link
Contributor

odersky commented Jul 28, 2015

What's the partest failure? Should we try to merge this or work on the branch separately

@DarkDimius
Fix scala#744
7cfa2e1 
Mixi was not calling transformFollowing on generated setters.
@DarkDimius
Fix scala#745, memoise should be able to get type of field from setter.
3377de5
@DarkDimius
Copy link
Contributor Author

DarkDimius commented Jul 28, 2015

The failure is due to incorrect check file added in this pr(extra line break). It should be fixed now.

@DarkDimius
Copy link
Contributor Author

DarkDimius commented Jul 28, 2015

@odersky tests passed, please review

@odersky
Applied review comments
d528035 
Added suggested changes by myself and @smarter.
@odersky
Copy link
Contributor

odersky commented Aug 4, 2015

LGTM for everything.

odersky added a commit that referenced this pull request Aug 4, 2015
@odersky
Merge pull request #735 from dotty-staging/ycheck-methods
07e24e8 
Ycheck that methods defined in ClassInfo exist in tree.
@odersky odersky merged commit 07e24e8 into scala:master Aug 4, 2015
@allanrenucci allanrenucci deleted the ycheck-methods branch December 14, 2017 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DarkDimius @odersky @smarter @dottybot