Skip to content

Constructors: fixes to maintain needed private fields. #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DarkDimius merged 7 commits into from
Sep 14, 2015
Merged

Constructors: fixes to maintain needed private fields. #774

DarkDimius merged 7 commits into from
Sep 14, 2015

Conversation

@DarkDimius
Copy link
Contributor

@DarkDimius DarkDimius commented Aug 24, 2015

fixes #772

@DarkDimius
Memoize: call transformFollowingDeep with correct owner.
96d2bd1
@DarkDimius
Constructors: gather retained private vals in advance.
030ab74 
Allows not to go deep into tree,
additionally fixes bugs with fields that are only used in inner classes
being removed.
@DarkDimius
Constructors: Do not store private fields used only to initialise oth…
86e83af 
…er fields
@DarkDimius
Constructors: remove self validation.
a33eece 
Curiously enough, it only found bugs in old scheme
It was deleting accessors, that used to be vals
but became defs without anybody raising the `Method` flag.
@DarkDimius
Add comment to Compiler.scala about behaviour of Constructors
56b1951
@DarkDimius DarkDimius changed the title Constructos: fixes to maintain needed private fields. Constructors: fixes to maintain needed private fields. Aug 24, 2015
@DarkDimius
Copy link
Contributor Author

DarkDimius commented Aug 24, 2015

error sbt.ResolveException: unresolved dependency: org.scala-sbt#relation;0.13.5: not found

/rebuild

@DarkDimius
Copy link
Contributor Author

DarkDimius commented Aug 24, 2015

@odersky please review

smarter
smarter reviewed Aug 24, 2015
View reviewed changes
src/dotty/tools/dotc/transform/Constructors.scala Outdated
Copy link
Member

@smarter smarter Aug 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoha! You probably don't want to keep this :)

DarkDimius added a commit to dotty-staging/dotty that referenced this pull request Aug 25, 2015
@DarkDimius
Address review comments scala#774
5852560
smarter
smarter reviewed Aug 25, 2015
View reviewed changes
src/dotty/tools/dotc/transform/Constructors.scala Outdated
Copy link
Member

@smarter smarter Aug 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return value of this match is not used anywhere.

Copy link
Contributor Author

@DarkDimius DarkDimius Aug 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this match returns Unit. How could it be used?

Copy link
Member

@smarter smarter Aug 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, I missed that retain had side-effects, I suggest replacing def retain by def retain() and using retain() to follow the scala style.

@DarkDimius
Copy link
Contributor Author

DarkDimius commented Aug 25, 2015

error sbt.ResolveException: download failed: com.typesafe.sbteclipse#sbteclipse-core;2.2.0!sbteclipse-core.jar

/rebuild

@DarkDimius
Copy link
Contributor Author

DarkDimius commented Aug 25, 2015

/rebuild

odersky
odersky reviewed Aug 28, 2015
View reviewed changes
src/dotty/tools/dotc/transform/Constructors.scala Outdated
Copy link
Contributor

@odersky odersky Aug 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reverse the order of the two conditions in the &&. mightBeDropped makes sense only for class members.

@odersky
Copy link
Contributor

odersky commented Aug 28, 2015

Otherwise LGTM

DarkDimius added a commit to dotty-staging/dotty that referenced this pull request Sep 9, 2015
@DarkDimius
Address review comments of scala#774
2ee4caa
DarkDimius added a commit that referenced this pull request Sep 14, 2015
@DarkDimius
Merge pull request #774 from dotty-staging/fix-constructors
4f2e912 
Constructors: fixes to maintain needed private fields.
@DarkDimius DarkDimius merged commit 4f2e912 into scala:master Sep 14, 2015
@allanrenucci allanrenucci deleted the fix-constructors branch December 14, 2017 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Constructors removes private fields used only in inner classes

3 participants

@DarkDimius @odersky @smarter