Skip to content

fix compiling ScalaRunTime.scala #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
odersky merged 2 commits into from
Oct 2, 2015
Merged

fix compiling ScalaRunTime.scala #804

odersky merged 2 commits into from
Oct 2, 2015

Conversation

@svalaskevicius
Copy link
Contributor

@svalaskevicius svalaskevicius commented Sep 24, 2015

this PR fixes compiling ScalaRunTime.scala (from dotty repo):

before:

exception occurred while compiling ../src/scala/runtime/ScalaRunTime.scala
Exception in thread "main" java.lang.Error: internal error: type of pattern variable ? is not fully defined, pos = [3339..3345]
    at dotty.tools.dotc.typer.Inferencing$class.fullyDefinedType(Inferencing.scala:44)
    at dotty.tools.dotc.typer.Typer.fullyDefinedType(Typer.scala:58)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedBind$1.apply(Typer.scala:853)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedBind$1.apply(Typer.scala:852)
    at dotty.tools.dotc.util.Stats$.track(Stats.scala:36)
    at dotty.tools.dotc.typer.Typer.typedBind(Typer.scala:852)
    at dotty.tools.dotc.typer.Typer.typedNamed$1(Typer.scala:1022)
    at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:1078)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1090)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1088)
    at dotty.tools.dotc.reporting.Reporting$class.traceIndented(Reporter.scala:148)
    at dotty.tools.dotc.core.Contexts$Context.traceIndented(Contexts.scala:53)
    at dotty.tools.dotc.typer.Typer.typed(Typer.scala:1088)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedIdent$1.apply(Typer.scala:256)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedIdent$1.apply(Typer.scala:79)
    at dotty.tools.dotc.util.Stats$.track(Stats.scala:36)
    at dotty.tools.dotc.typer.Typer.typedIdent(Typer.scala:79)
    at dotty.tools.dotc.typer.Typer.typedNamed$1(Typer.scala:1019)
    at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:1078)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1090)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1088)
    at dotty.tools.dotc.reporting.Reporting$class.traceIndented(Reporter.scala:148)
    at dotty.tools.dotc.core.Contexts$Context.traceIndented(Contexts.scala:53)
    at dotty.tools.dotc.typer.Typer.typed(Typer.scala:1088)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedAppliedTypeTree$1.apply(Typer.scala:829)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedAppliedTypeTree$1.apply(Typer.scala:828)
    at dotty.tools.dotc.util.Stats$.track(Stats.scala:36)
    at dotty.tools.dotc.typer.Typer.typedAppliedTypeTree(Typer.scala:828)
    at dotty.tools.dotc.typer.Typer.typedUnnamed$1(Typer.scala:1064)
    at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:1080)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1090)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1088)
    at dotty.tools.dotc.reporting.Reporting$class.traceIndented(Reporter.scala:148)
    at dotty.tools.dotc.core.Contexts$Context.traceIndented(Contexts.scala:53)
    at dotty.tools.dotc.typer.Typer.typed(Typer.scala:1088)
    at dotty.tools.dotc.typer.Typer.typedType(Typer.scala:1129)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedTyped$1.regularTyped$1(Typer.scala:372)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedTyped$1.apply(Typer.scala:380)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedTyped$1.apply(Typer.scala:366)
    at dotty.tools.dotc.util.Stats$.track(Stats.scala:36)
    at dotty.tools.dotc.typer.Typer.typedTyped(Typer.scala:366)
    at dotty.tools.dotc.typer.Typer.typedUnnamed$1(Typer.scala:1045)
    at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:1080)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1090)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1088)
    at dotty.tools.dotc.reporting.Reporting$class.traceIndented(Reporter.scala:148)
    at dotty.tools.dotc.core.Contexts$Context.traceIndented(Contexts.scala:53)
    at dotty.tools.dotc.typer.Typer.typed(Typer.scala:1088)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedBind$1.apply(Typer.scala:854)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedBind$1.apply(Typer.scala:852)
    at dotty.tools.dotc.util.Stats$.track(Stats.scala:36)
    at dotty.tools.dotc.typer.Typer.typedBind(Typer.scala:852)
    at dotty.tools.dotc.typer.Typer.typedNamed$1(Typer.scala:1022)
    at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:1078)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1090)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1088)
    at dotty.tools.dotc.reporting.Reporting$class.traceIndented(Reporter.scala:148)
    at dotty.tools.dotc.core.Contexts$Context.traceIndented(Contexts.scala:53)
    at dotty.tools.dotc.typer.Typer.typed(Typer.scala:1088)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedTyped$1.apply(Typer.scala:384)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedTyped$1.apply(Typer.scala:366)
    at dotty.tools.dotc.util.Stats$.track(Stats.scala:36)
    at dotty.tools.dotc.typer.Typer.typedTyped(Typer.scala:366)
    at dotty.tools.dotc.typer.Typer.typedUnnamed$1(Typer.scala:1045)
    at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:1080)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1090)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1088)
    at dotty.tools.dotc.reporting.Reporting$class.traceIndented(Reporter.scala:148)
    at dotty.tools.dotc.core.Contexts$Context.traceIndented(Contexts.scala:53)
    at dotty.tools.dotc.typer.Typer.typed(Typer.scala:1088)
    at dotty.tools.dotc.typer.Typer.typedPattern(Typer.scala:1131)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedCase$1.apply(Typer.scala:693)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedCase$1.apply(Typer.scala:668)
    at dotty.tools.dotc.util.Stats$.track(Stats.scala:36)
    at dotty.tools.dotc.typer.Typer.typedCase(Typer.scala:668)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedCases$1.apply(Typer.scala:662)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedCases$1.apply(Typer.scala:662)
    at dotty.tools.dotc.core.Decorators$ListDecorator$.loop$1(Decorators.scala:51)
    at dotty.tools.dotc.core.Decorators$ListDecorator$.mapconserve$extension(Decorators.scala:67)
    at dotty.tools.dotc.typer.Typer.typedCases(Typer.scala:662)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedMatch$1.apply(Typer.scala:634)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedMatch$1.apply(Typer.scala:626)
    at dotty.tools.dotc.util.Stats$.track(Stats.scala:36)
    at dotty.tools.dotc.typer.Typer.typedMatch(Typer.scala:625)
    at dotty.tools.dotc.typer.Typer.typedUnnamed$1(Typer.scala:1052)
    at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:1080)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1090)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1088)
    at dotty.tools.dotc.reporting.Reporting$class.traceIndented(Reporter.scala:148)
    at dotty.tools.dotc.core.Contexts$Context.traceIndented(Contexts.scala:53)
    at dotty.tools.dotc.typer.Typer.typed(Typer.scala:1088)
    at dotty.tools.dotc.typer.Typer.typedExpr(Typer.scala:1127)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedDefDef$1.apply(Typer.scala:895)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedDefDef$1.apply(Typer.scala:888)
    at dotty.tools.dotc.util.Stats$.track(Stats.scala:36)
    at dotty.tools.dotc.typer.Typer.typedDefDef(Typer.scala:888)
    at dotty.tools.dotc.typer.Typer.typedNamed$1(Typer.scala:1028)
    at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:1078)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1090)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1088)
    at dotty.tools.dotc.reporting.Reporting$class.traceIndented(Reporter.scala:148)
    at dotty.tools.dotc.core.Contexts$Context.traceIndented(Contexts.scala:53)
    at dotty.tools.dotc.typer.Typer.typed(Typer.scala:1088)
    at dotty.tools.dotc.typer.Typer.traverse$1(Typer.scala:1112)
    at dotty.tools.dotc.typer.Typer.typedStats(Typer.scala:1123)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedClassDef$1.apply(Typer.scala:924)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedClassDef$1.apply(Typer.scala:907)
    at dotty.tools.dotc.util.Stats$.track(Stats.scala:36)
    at dotty.tools.dotc.typer.Typer.typedClassDef(Typer.scala:907)
    at dotty.tools.dotc.typer.Typer.typedNamed$1(Typer.scala:1031)
    at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:1078)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1090)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1088)
    at dotty.tools.dotc.reporting.Reporting$class.traceIndented(Reporter.scala:148)
    at dotty.tools.dotc.core.Contexts$Context.traceIndented(Contexts.scala:53)
    at dotty.tools.dotc.typer.Typer.typed(Typer.scala:1088)
    at dotty.tools.dotc.typer.Typer.traverse$1(Typer.scala:1112)
    at dotty.tools.dotc.typer.Typer.typedStats(Typer.scala:1123)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedPackageDef$1.apply(Typer.scala:971)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedPackageDef$1.apply(Typer.scala:962)
    at dotty.tools.dotc.util.Stats$.track(Stats.scala:36)
    at dotty.tools.dotc.typer.Typer.typedPackageDef(Typer.scala:962)
    at dotty.tools.dotc.typer.Typer.typedUnnamed$1(Typer.scala:1068)
    at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:1080)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1090)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1088)
    at dotty.tools.dotc.reporting.Reporting$class.traceIndented(Reporter.scala:148)
    at dotty.tools.dotc.core.Contexts$Context.traceIndented(Contexts.scala:53)
    at dotty.tools.dotc.typer.Typer.typed(Typer.scala:1088)
    at dotty.tools.dotc.typer.Typer.traverse$1(Typer.scala:1118)
    at dotty.tools.dotc.typer.Typer.typedStats(Typer.scala:1123)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedPackageDef$1.apply(Typer.scala:971)
    at dotty.tools.dotc.typer.Typer$$anonfun$typedPackageDef$1.apply(Typer.scala:962)
    at dotty.tools.dotc.util.Stats$.track(Stats.scala:36)
    at dotty.tools.dotc.typer.Typer.typedPackageDef(Typer.scala:962)
    at dotty.tools.dotc.typer.Typer.typedUnnamed$1(Typer.scala:1068)
    at dotty.tools.dotc.typer.Typer.typedUnadapted(Typer.scala:1080)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1090)
    at dotty.tools.dotc.typer.Typer$$anonfun$typed$2.apply(Typer.scala:1088)
    at dotty.tools.dotc.reporting.Reporting$class.traceIndented(Reporter.scala:148)
    at dotty.tools.dotc.core.Contexts$Context.traceIndented(Contexts.scala:53)
    at dotty.tools.dotc.typer.Typer.typed(Typer.scala:1088)
    at dotty.tools.dotc.typer.Typer.typedExpr(Typer.scala:1127)
    at dotty.tools.dotc.typer.FrontEnd$$anonfun$typeCheck$1.apply$mcV$sp(FrontEnd.scala:42)
    at dotty.tools.dotc.typer.FrontEnd.monitor(FrontEnd.scala:19)
    at dotty.tools.dotc.typer.FrontEnd.typeCheck(FrontEnd.scala:40)
    at dotty.tools.dotc.typer.FrontEnd$$anonfun$runOn$3.apply(FrontEnd.scala:53)
    at dotty.tools.dotc.typer.FrontEnd$$anonfun$runOn$3.apply(FrontEnd.scala:53)
    at scala.collection.immutable.List.foreach(List.scala:381)
    at dotty.tools.dotc.typer.FrontEnd.runOn(FrontEnd.scala:53)
    at dotty.tools.dotc.Run$$anonfun$compileUnits$1$$anonfun$apply$mcV$sp$1.apply(Run.scala:59)
    at dotty.tools.dotc.Run$$anonfun$compileUnits$1$$anonfun$apply$mcV$sp$1.apply(Run.scala:56)
    at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
    at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:186)
    at dotty.tools.dotc.Run$$anonfun$compileUnits$1.apply$mcV$sp(Run.scala:56)
    at dotty.tools.dotc.Run$$anonfun$compileUnits$1.apply(Run.scala:52)
    at dotty.tools.dotc.Run$$anonfun$compileUnits$1.apply(Run.scala:52)
    at dotty.tools.dotc.util.Stats$.monitorHeartBeat(Stats.scala:69)
    at dotty.tools.dotc.Run.compileUnits(Run.scala:52)
    at dotty.tools.dotc.Run.compileSources(Run.scala:49)
    at dotty.tools.dotc.Run.compile(Run.scala:33)
    at dotty.tools.dotc.Driver.doCompile(Driver.scala:21)
    at dotty.tools.dotc.Driver.process(Driver.scala:44)
    at dotty.tools.dotc.Driver.main(Driver.scala:48)
    at dotty.tools.dotc.Main.main(Main.scala)

after:

 ~/p/d/d/build fix-compiling-ScalaRunTime: ! [20:12]> ../bin/dotc -print -verbose ../src//scala/runtime/ScalaRunTime.scala
warning: encountered F-bounded higher-kinded type parameters for type scala$collection$generic$GenMapFactory$$CC; assuming they are invariant
warning: encountered F-bounded higher-kinded type parameters for type scala$collection$generic$MapFactory$$CC; assuming they are invariant
two warnings found

Please let me know if the change should be updated (e.g. should the mode retract be in another place instead?)

Also, I would like to add some test cases.. but couldnt find a convenient way to run just one specific test via command line - can you help with this? it would make much simpler to debug/fix issues :)

@svalaskevicius
Copy link
Contributor Author

svalaskevicius commented Sep 25, 2015

Hi @DarkDimius, @odersky,

Please can you have a look at this PR and let me know what should be improved so that it could be merged?

After this and the other pr (#806) there is just one error left.. (SymbolicXMLBuilder.scala:6: error: xml is not a member of scala.type) (and a gazillion of warnings, so might not work just yet)

Thanks

@DarkDimius
Copy link
Contributor

DarkDimius commented Sep 25, 2015

Also, I would like to add some test cases.. but couldnt find a convenient way to run just one specific test via command line - can you help with this? it would make much simpler to debug/fix issues :)

You can either use partest for this, or use test suite:
https://github.com/lampepfl/dotty/blob/master/test/dotc/tests.scala
I do the later(set up the tests that I want to track and run them with ~testOnly dotc.tests).

@svalaskevicius
Copy link
Contributor Author

svalaskevicius commented Sep 25, 2015

thanks, will play around with the test suite :)

@svalaskevicius svalaskevicius force-pushed the fix-compiling-ScalaRunTime branch from 5d4c9ce to 4eed95a Compare September 25, 2015 15:03
@svalaskevicius
Copy link
Contributor Author

svalaskevicius commented Sep 25, 2015

@DarkDimius: added a test (also confirmed that it fails on master)
its based on https://github.com/lampepfl/dotty/blob/ef274600378cc55b78ad62ac9afc8ce9a21efb89/src/scala/runtime/ScalaRunTime.scala#L67

@svalaskevicius svalaskevicius force-pushed the fix-compiling-ScalaRunTime branch from 4eed95a to 1c131d5 Compare September 25, 2015 15:21
@odersky
Copy link
Contributor

odersky commented Oct 2, 2015

LGTM. Thanks for the fix!

odersky added a commit that referenced this pull request Oct 2, 2015
@odersky
Merge pull request #804 from svalaskevicius/fix-compiling-ScalaRunTime
5f7e290 
fix compiling ScalaRunTime.scala
@odersky odersky merged commit 5f7e290 into scala:master Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@svalaskevicius @DarkDimius @odersky @dottybot