remove outdated difference of match types with typescript's conditional types #9724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typescript supports binding of variables within the pattern
dottybot
reviewed
Sep 4, 2020
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the part about match types supporting variables within the pattern is no longer a difference. Typescript supports binding of variables within the pattern. I've written up a small example:
https://www.typescriptlang.org/play?#code/C4TwDgpgBAogNhAthAdsA8gMwDwA0B8UAvFAFBQVS5QQAewqAJgM5QAUAliphAE6wBKANoBdKAH5YUAFzlK1OgxQsoAbyEBrCCGlRmwXlwDmI3Z259BAXwlTdKCADc+AblKkAxgHsU+mgEZdeCRUDBwUAFdEACM+UUISAGY3b19gGgAmIIRkNCxsdS0dPQNjUxLDFCMrBKgAIkwvLzqUnz8IROyQvJx9SqN44ihkoA
Is the difference outdated or am I just misunderstanding what "Match types can bind variables in type patterns" means?