Skip to content

Conversation

@tiffzhao5
Copy link
Contributor

@tiffzhao5 tiffzhao5 commented Nov 1, 2023

Added unit test to this: #338

Needed to rebase so created a separate PR.

Querying ECR to check for existing images for each inference framework.

@yunfeng-scale
Copy link
Contributor

thanks for the contributions!

i'm worried about the overhead of adding these tags / redeploy model engine server whenever we're adding a new image. possible to query ECR and check existence of the image?

@tiffzhao5
Copy link
Contributor Author

thanks for the contributions!

i'm worried about the overhead of adding these tags / redeploy model engine server whenever we're adding a new image. possible to query ECR and check existence of the image?

hm I see that's a good suggestion, I'll give it a try and see if it works!

@tiffzhao5 tiffzhao5 changed the title Unit test for validating inference framework image tags Validating inference framework image tags Nov 3, 2023
@tiffzhao5
Copy link
Contributor Author

thanks for the contributions!
i'm worried about the overhead of adding these tags / redeploy model engine server whenever we're adding a new image. possible to query ECR and check existence of the image?

hm I see that's a good suggestion, I'll give it a try and see if it works!

@yunfeng-scale I implemented querying ECR -- what are your thoughts?

@yunfeng-scale
Copy link
Contributor

it seems a some commits were reverted, can you bring them back?

Copy link
Contributor

@yunfeng-scale yunfeng-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix @yixu34 's comment

@tiffzhao5 tiffzhao5 enabled auto-merge (squash) November 9, 2023 02:20
@tiffzhao5 tiffzhao5 merged commit a5dbfa5 into main Nov 9, 2023
@tiffzhao5 tiffzhao5 deleted the tiffany/validate branch November 9, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants