Skip to content

Conversation

@saiatmakuri
Copy link
Contributor

https://docs.datadoghq.com/tracing/metrics/metrics_namespace/

Trace metrics tags, possible tags are: env, service, version, resource, sublayer_type, sublayer_service, http.status_code, http.status_class, Datadog Agent tags (including the host and second primary tag). Note: Tags set on spans do not count and will not be available as tags for your traces metrics.

There already is a resource trace metric tag. launch.resource_name is also a facet that's unused, so it can be removed

@saiatmakuri saiatmakuri self-assigned this Nov 1, 2023
@ian-scale
Copy link
Contributor

@saiatmakuri I don't think this is the case, but can you confirm this facet isn't being used for any of our datadog dashboards before we remove it?

@saiatmakuri
Copy link
Contributor Author

@saiatmakuri I don't think this is the case, but can you confirm this facet isn't being used for any of our datadog dashboards before we remove it?

checked again to confirm, we only use the trace metric resource_name

@saiatmakuri saiatmakuri enabled auto-merge (squash) November 2, 2023 17:36
Copy link
Member

@yixu34 yixu34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 👌🏻

@saiatmakuri saiatmakuri merged commit 4c83d54 into main Nov 2, 2023
@saiatmakuri saiatmakuri deleted the saiatmakuri/remove-extra-resource-name-trace-facet branch November 2, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants