Enable custom istio metric tags with Telemetry API #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
We can now tag metrics at the istio-level with API-routes. Istio-level metrics serve as a better source of truth for request counts.
We are using the alpha Telemetry APIs here: https://istio.io/latest/docs/tasks/observability/metrics/classify-metrics/
The actual routes were generated with an internal script from the OpenAPI service spec. The script will be open-sourced later.
Test Plan and Usage Guide
Applied the new yamls to test cluster. Pinged the service a few times and observed new tags in prometheus metrics
Command
New metric example, notice
request_operationtag