Add emitting token count metrics to datadog statsd #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanshi-scale
commented
Mar 1, 2024
model-engine/model_engine_server/infra/gateways/datadog_monitoring_metrics_gateway.py
Show resolved
Hide resolved
saiatmakuri
approved these changes
Mar 26, 2024
| ): | ||
| return None | ||
| if self.num_completion_tokens < 2: | ||
| return 0.0 |
Contributor
There was a problem hiding this comment.
should this return None since there were no tokens after the first?
Contributor
Author
There was a problem hiding this comment.
yeah good point, made the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
We want to be able to view token count metrics.
Test Plan and Usage Guide
Deployed test deployment to Scale's infra, metrics do appear