Add max_model_len as Optional Argument for Model.create API #661
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
Member
|
Any tests to update/create? |
ghost
changed the title
dmchoiboi
reviewed
Nov 18, 2024
model-engine/model_engine_server/domain/use_cases/llm_model_endpoint_use_cases.py
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
sghanta/mli_1696
branch
from
8188b8d to
1a7bcf1
Compare
Author
There seems to be an already existing test |
dmchoiboi
approved these changes
Nov 19, 2024
Pass said parameter to vLLM engine if requested by user
ghost
force-pushed
the
sghanta/mli_1696
branch
from
1a7bcf1 to
58d9eae
Compare
ghost
changed the title
dmchoiboi
approved these changes
Nov 19, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass said parameter to vLLM engine if requested by user