Fix development issues and poetry install (specifically related to arm64/Apply Silicon) - Drop Python 3.6 support" #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatli
force-pushed
the
gunnar/fix-poetry-install
branch
from
90a4329 to
a7d8d9b
Compare
ntamas92
approved these changes
Sep 18, 2023
| poetry run black --check . | ||
| - run: | ||
| name: Flake8 Lint Check # Uses setup.cfg for configuration | ||
| name: Ruff Lint Check # See pyproject.tooml [tool.ruff] |
Contributor
There was a problem hiding this comment.
Small typo
Suggested change
| name: Ruff Lint Check # See pyproject.tooml [tool.ruff] | |
| name: Ruff Lint Check # See pyproject.toml [tool.ruff] |
Contributor
Author
There was a problem hiding this comment.
Oops, had automerge on 🙂
Contributor
There was a problem hiding this comment.
No worries, I'll handle these in my PR soon.
| - repo: local | ||
| hooks: | ||
| - id: system | ||
| name: flake8 |
Contributor
There was a problem hiding this comment.
Better yet, maybe call it lint?
Suggested change
| name: flake8 | |
| name: ruff |
jean-lucas
approved these changes
Sep 18, 2023
Contributor
jean-lucas
left a comment
jean-lucas
left a comment
There was a problem hiding this comment.
lgtm, tried it out on a few sample scripts locally too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops Python 3.6 support it is end of life for security fixes for more than a year
This PR fixes
poetry installproblems for later python versions, allowing development on all modern Python versions.This basically required digging into different elements of the dependency tree and opening it up (which is a good idea for libraries)