Expose embedding indexes of Dataset #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm not a big fan of the |
Contributor
Author
|
@pfmark Good point, renamed! |
ntamas92
changed the title
ntamas92
commented
Nov 6, 2023
| status: IndexStatus | ||
| index_type: IndexType | ||
| index_level: IndexLevel | ||
| embedding_type: str |
Contributor
Author
There was a problem hiding this comment.
Would it make sense to create an enum for this one as well? I was hesitant because it contains valid values like EfficientNetB7 but also arbitrary ones like unknown
Contributor
There was a problem hiding this comment.
we can try w/o it for now
jean-lucas
approved these changes
Nov 6, 2023
CHANGELOG.md
Outdated
|
|
||
| ### Added | ||
| - Allow direct embedding vector upload together with dataset items. `DatasetItem` now has an additional parameter called `embedding_info` which can be used to directly upload embeddings when a dataset is uploaded. | ||
| - Added `dataset.search_indexes` property, which exposes information about every search index which belongs to the dataset. |
Contributor
There was a problem hiding this comment.
is it embedding_indexes now or search_indexes?
Contributor
There was a problem hiding this comment.
should also be embedding_indexes
Contributor
Author
There was a problem hiding this comment.
Nice catch, thanks!
Comment on lines
+29
to
+30
| @dataclass | ||
| class EmbeddingIndex: |
| status: IndexStatus | ||
| index_type: IndexType | ||
| index_level: IndexLevel | ||
| embedding_type: str |
Contributor
There was a problem hiding this comment.
we can try w/o it for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.