Skip to content

Conversation

@jean-lucas
Copy link
Contributor

Making individual requests to download_pointcloud_task(task_id, frame_num) was slow.

A new method is proposed to allow concurrent fetches of multiple tasks, with download_pointcloud_tasks(task_ids, frame_num)

return (request, data)


async def _parse_async_response(endpoint, session, response, sleep_time):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extracted from function above

@jean-lucas jean-lucas requested review from gatli and pfmark November 21, 2023 14:35
@jean-lucas jean-lucas self-assigned this Nov 21, 2023
Copy link
Contributor

@gatli gatli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🔥

@jean-lucas jean-lucas merged commit f2dbd31 into master Nov 22, 2023
@jean-lucas jean-lucas deleted the jean-lucas-concurrent-task-fetch branch November 22, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants