Skip to content

Conversation

@gatli
Copy link
Contributor

@gatli gatli commented Nov 29, 2023

Pydantic is very commonly used in codebases for payload validation. Adding scale-nucleus as a dependency pins users to Pydantic v1 which is totally incompatible with Pydantic v2.

We solve this problem by opening up the dependencies to support >=v1 and making sure that we always pick the v1 layer that is included in v2.

@gatli gatli requested a review from jean-lucas November 29, 2023 19:19
@gatli gatli self-assigned this Nov 29, 2023
Copy link
Contributor

@jean-lucas jean-lucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gatli gatli merged commit 1cf00b9 into master Nov 29, 2023
@gatli gatli deleted the gunnar/interoperability-with-pydantic-v2 branch November 29, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants