Add S3_ENDPOINT to customize S3 endpoint URL #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-lucas
approved these changes
Feb 29, 2024
Contributor
jean-lucas
left a comment
jean-lucas
left a comment
There was a problem hiding this comment.
LGTM once the change log conflicts are fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain environments, the S3 Endpoint URL is nonstandard and needs to be set to a specific value. This is particularly important when asking the Scale backend for a presigned S3 URL.
This is in combination with this commit on the main Scale monorepo: https://github.com/scaleapi/scaleapi/pull/76269/commits/69a721081813249b7ecdd54bdaa18be60fb9d3ef