Da/slice support #57
Merged
Da/slice support #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardila
force-pushed
the
da/slice-support
branch
from
8482fb6 to
f588832
Compare
ardila
force-pushed
the
da/slice-support
branch
from
eff16be to
77023a1
Compare
Contributor
Author
|
From our meeting with smartdesign it sounds like they would actually like to include the annotations, so I will change this to slice.items_and_annotations() |
srikanth-scale-2
approved these changes
Apr 21, 2021
Contributor
srikanth-scale-2
left a comment
srikanth-scale-2
left a comment
There was a problem hiding this comment.
lgtm, thanks circle ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for getting items and annotations within a slice
slice.items_and_annotations
Add support for annotating items within a slice (along with optional membership check)
slice.annotate
Tested by writing integration tests that do this against prod.
Primary reviewer
srikanth