Minor bugfixes #64
Merged
Minor bugfixes #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardila
commented
Apr 26, 2021
| for unit in upload_unit: | ||
| try: | ||
| file_pointer.write(unit.to_json()) | ||
| file_pointer.write(unit.to_json() + "\n") |
Contributor
Author
There was a problem hiding this comment.
Was trying to make this ndjson format, but forgot to add the newlines.
jihan-yin
approved these changes
Apr 26, 2021
ardila
commented
Apr 26, 2021
| if bool(dataset_item_ids) == bool(reference_ids): | ||
| raise Exception( | ||
| "You cannot specify both dataset_item_ids and reference_ids" | ||
| "You must specify exactly one of dataset_item_ids or reference_ids." |
Contributor
Author
There was a problem hiding this comment.
This was the bug that made the error much harder to find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.