CLI failing execution when called from a script executed by cloud-init

[marcociarrocca]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Command attempted

scw init secret-key=${scw-secret-key} send-telemetry=false install-autocomplete=false with-ssh-key=false -c "/root/.config/scw/config.yaml"
scw instance ip create -c "/root/.config/scw/config.yaml" project-id=${project-id} server=${server-id} zone=${scw-zone}

Expected Behavior

A public IP is created and attached to the server instance.

Actual Behavior

When executed manually, everything works correctly.
When executed by a script called by cloud-init, the following error is thrown by both commands: Scaleway-sdk-go: cannot read config file: read .: is a directory
When omitting the -c flag, the following error is thrown by the scw init command: Open .: is a directory; the ip create command fails with the same error reported above.
Omitting the -c flag and specifying the SCW_CONFIG_PATH env variable shows no difference.
The config file seems to get created correctly (and on the right path, when specified), while the ip create command always fails (does not create the IP).
Executing the commands either manually or via a manually-executed script (after SSHing into the instance) works correctly.

More info

scw version:
Version    2.3.1
BuildDate  2021-06-08T11:54:02
GoVersion  go1.16.4
GitBranch  new-release
GitCommit  07dbaebc
GoArch     amd64
GoOS       linux

uname:
Linux 5.10.28-scaleway #1 SMP x86_64 GNU/Linux

[kerberjg]

I've been trying to read the source code of both scaleway-cli and scaleway-sdk-go (since the latter seems to be mentioned by the error) and I've found that what happens is essentially this:

• scaleway-cli tries to get the config file path from 3 sources, in order of priority: -c flag, '$HOME/.config/scw/config.yaml', and finally $SCW_CONFIG_FILE

  scaleway-cli/internal/namespaces/config/commands.go

  Line 262 in d8a0253

  configPath := core.ExtractConfigPath(ctx)

  ,

  scaleway-cli/internal/core/context.go

  Line 146 in d8a0253

  func ExtractConfigPath(ctx context.Context) string {

• One of those is being interpreted as . since that's what seems to be the extrapolated path
• scaleway-sdk-go tries to open it, spitting the cannot read config file error;

  scaleway-cli/internal/namespaces/config/commands.go

  Line 263 in d8a0253

  config, err := scw.LoadConfigFromPath(configPath)

  , https://github.com/scaleway/scaleway-sdk-go/blob/043be10c857c516a5dadd1b277eceb2207eeacab/scw/config.go#L203

Furthermore, the -c flag is being extrapolated in the bootstrap.go file, but there's a mistake;

scaleway-cli/internal/core/bootstrap.go

Line 228 in 5332ec1

rootCmd.PersistentFlags().StringVarP(&configPathFlag, "profile", "p", "", "The config profile to use")

The references to profileFlag and configFileFlag are swapped.
I wonder if this is of significance given that they're being read (?) correctly earlier on.

scaleway-cli/internal/core/bootstrap.go

Line 79 in 5332ec1

flags.StringVarP(&configPathFlag, "config", "c", "", "The path to the config file")

Pinging @jerome-quere for relevance

[Codelax]

Broken config flag has been fix with #2476. It will be included in next release

[Codelax]

Also, scw init secret-key=${secret-key} will still open interactive prompt to fill access key even tho it is not needed. I will disable this interactive prompt and it should be good