Skip to content

feat(k8s): add support for pool volume type #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyleone merged 3 commits into from
Apr 12, 2022
Merged

feat(k8s): add support for pool volume type #2256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8b5646
feat: update generated cli
scaleway-bot Apr 12, 2022
438ee0c
Merge branch 'master' into v1.2339.0
remyleone Apr 12, 2022
6a7eda2
Fix
remyleone Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/scw/testdata/test-all-usage-k8s-cluster-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ ARGS:
[pools.{index}.upgrade-policy.max-unavailable] The maximum number of nodes that can be not ready at the same time
[pools.{index}.upgrade-policy.max-surge] The maximum number of nodes to be created during the upgrade
[pools.{index}.zone] The Zone in which the Pool's node will be spawn in
[pools.{index}.root-volume-type] The system volume disk type (default_volume_type | l_ssd | b_ssd)
[pools.{index}.root-volume-size] The system volume disk size
[autoscaler-config.scale-down-disabled] Disable the cluster autoscaler
[autoscaler-config.scale-down-delay-after-add] How long after scale up that scale down evaluation resumes
[autoscaler-config.estimator] Type of resource estimator to be used in scale up (unknown_estimator | binpacking)
Expand Down
2 changes: 2 additions & 0 deletions cmd/scw/testdata/test-all-usage-k8s-pool-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ ARGS:
[upgrade-policy.max-unavailable]
[upgrade-policy.max-surge]
[zone] The Zone in which the Pool's node will be spawn in
[root-volume-type] The system volume disk type (default_volume_type | l_ssd | b_ssd)
[root-volume-size] The system volume disk size
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
Expand Down
4 changes: 4 additions & 0 deletions docs/commands/k8s.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ scw k8s cluster create [arg=value ...]
| pools.{index}.upgrade-policy.max-unavailable | | The maximum number of nodes that can be not ready at the same time |
| pools.{index}.upgrade-policy.max-surge | | The maximum number of nodes to be created during the upgrade |
| pools.{index}.zone | | The Zone in which the Pool's node will be spawn in |
| pools.{index}.root-volume-type | One of: `default_volume_type`, `l_ssd`, `b_ssd` | The system volume disk type |
| pools.{index}.root-volume-size | | The system volume disk size |
| autoscaler-config.scale-down-disabled | | Disable the cluster autoscaler |
| autoscaler-config.scale-down-delay-after-add | | How long after scale up that scale down evaluation resumes |
| autoscaler-config.estimator | One of: `unknown_estimator`, `binpacking` | Type of resource estimator to be used in scale up |
Expand Down Expand Up @@ -728,6 +730,8 @@ scw k8s pool create [arg=value ...]
| upgrade-policy.max-unavailable | | |
| upgrade-policy.max-surge | | |
| zone | | The Zone in which the Pool's node will be spawn in |
| root-volume-type | One of: `default_volume_type`, `l_ssd`, `b_ssd` | The system volume disk type |
| root-volume-size | | The system volume disk size |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down
30 changes: 30 additions & 0 deletions internal/namespaces/k8s/v1/k8s_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,21 @@ func k8sClusterCreate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "pools.{index}.root-volume-type",
Short: `The system volume disk type`,
Required: false,
Deprecated: false,
Positional: false,
EnumValues: []string{"default_volume_type", "l_ssd", "b_ssd"},
},
{
Name: "pools.{index}.root-volume-size",
Short: `The system volume disk size`,
Required: false,
Deprecated: false,
Positional: false,
},
{
Name: "autoscaler-config.scale-down-disabled",
Short: `Disable the cluster autoscaler`,
Expand Down Expand Up @@ -1299,6 +1314,21 @@ func k8sPoolCreate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "root-volume-type",
Short: `The system volume disk type`,
Required: false,
Deprecated: false,
Positional: false,
EnumValues: []string{"default_volume_type", "l_ssd", "b_ssd"},
},
{
Name: "root-volume-size",
Short: `The system volume disk size`,
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms, scw.RegionPlWaw),
},
Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {
Expand Down