Skip to content

feat(instance): add support for project-default in instanceSecurityGroupList #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyleone merged 2 commits into from
Jun 13, 2022
Merged

feat(instance): add support for project-default in instanceSecurityGroupList #2346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e1d3ed
feat: update generated cli
scaleway-bot Jun 13, 2022
165cbad
FIx
remyleone Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-instance-security-group-list-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ ARGS:
[name] Name of the security group
[project-id] The security group project ID
[tags.{index}] List security groups with these exact tags (to filter with several tags, use commas to separate them)
[project-default] Filter security groups with this value for project_default
[organization-id] The security group organization ID
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | fr-par-3 | nl-ams-1 | nl-ams-2 | pl-waw-1)

Expand Down
1 change: 1 addition & 0 deletions docs/commands/instance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,6 +1056,7 @@ scw instance security-group list [arg=value ...]
| name | | Name of the security group |
| project-id | | The security group project ID |
| tags.{index} | | List security groups with these exact tags (to filter with several tags, use commas to separate them) |
| project-default | | Filter security groups with this value for project_default |
| organization-id | | The security group organization ID |
| zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `fr-par-3`, `nl-ams-1`, `nl-ams-2`, `pl-waw-1` | Zone to target. If none is passed will use default zone from the config |

Expand Down
7 changes: 7 additions & 0 deletions internal/namespaces/instance/v1/instance_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1782,6 +1782,13 @@ func instanceSecurityGroupList() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "project-default",
Short: `Filter security groups with this value for project_default`,
Required: false,
Deprecated: false,
Positional: false,
},
{
Name: "organization",
Short: `The security group organization ID`,
Expand Down