Skip to content

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Sep 16, 2022

Close #1478

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Merging #2513 (12d636c) into master (22c0726) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
+ Coverage   75.79%   75.81%   +0.01%     
==========================================
  Files         126      126              
  Lines       21791    21804      +13     
==========================================
+ Hits        16517    16530      +13     
  Misses       4715     4715              
  Partials      559      559              
Impacted Files Coverage Δ
internal/core/testing.go 65.61% <100.00%> (+1.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Codelax Codelax force-pushed the validate_json_goldens branch from aa123fe to 12d636c Compare September 16, 2022 14:06
@remyleone remyleone merged commit 364a689 into scaleway:master Sep 16, 2022
@Codelax Codelax self-assigned this Sep 22, 2022
@Monitob Monitob mentioned this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure that JSON output in golden are effectively JSON

4 participants