Skip to content

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Mar 29, 2023

Closes #1919

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Merging #2971 (907ec84) into master (ebfb936) will decrease coverage by 0.08%.
The diff coverage is 18.00%.

❗ Current head 907ec84 differs from pull request most recent head 08b7b20. Consider uploading reports for the commit 08b7b20 to get more accurate results

@@            Coverage Diff             @@
##           master    #2971      +/-   ##
==========================================
- Coverage   75.78%   75.71%   -0.08%     
==========================================
  Files         173      174       +1     
  Lines       37716    37761      +45     
==========================================
+ Hits        28582    28589       +7     
- Misses       8103     8138      +35     
- Partials     1031     1034       +3     
Impacted Files Coverage Δ
internal/core/command.go 39.33% <ø> (ø)
internal/core/web.go 7.40% <7.40%> (ø)
internal/core/cobra_builder.go 77.86% <25.00%> (-0.18%) ⬇️
internal/core/cobra_utils.go 65.10% <31.57%> (-3.69%) ⬇️

@Codelax Codelax marked this pull request as ready for review March 29, 2023 14:36
@remyleone remyleone added the priority:medium Improvements that are not the main priority label Apr 12, 2023
@remyleone remyleone enabled auto-merge June 6, 2023 13:35
@remyleone remyleone added this pull request to the merge queue Jun 6, 2023
Merged via the queue into scaleway:master with commit a41fc4e Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core enhancement priority:medium Improvements that are not the main priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a --web option to launch a console on a relevant page

3 participants