ARSN-533: Get raft session ID from metadata on getBucketAttributes and getBucketAndObjectMD #2560

dvasilas · 2025-10-21T13:30:24Z

bert-e · 2025-10-21T13:30:28Z

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-10-21T13:30:33Z

Incorrect fix version

The Fix Version/s in issue ARSN-533 contains:

8.2.34

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.2.34
8.3.0

Please check the Fix Version/s of ARSN-533, or the target
branch of this pull request.

bert-e · 2025-10-21T13:32:11Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

codecov · 2025-10-22T08:27:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.36%. Comparing base (7b9db24) to head (51640ec).
⚠️ Report is 2 commits behind head on development/8.2.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/8.2    #2560      +/-   ##
===================================================
+ Coverage            71.14%   71.36%   +0.21%     
===================================================
  Files                  221      221              
  Lines                17810    17810              
  Branches              3681     3681              
===================================================
+ Hits                 12671    12710      +39     
+ Misses                5135     5096      -39     
  Partials                 4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jonathan-gramain · 2025-10-22T21:06:58Z

lib/models/BucketInfo.ts

    capabilities?: Capabilities,
    quotaMax: bigint | number,
    bucketLoggingStatus?: BucketLoggingStatus,
+    raftSessionId?: number,


Do we really have to store this info in bucket metadata? It doesn't look like a good place to me, since it's not a property of the bucket, but extra info that we want the caller to know. I think ideally we should pass it along in a side channel (can be an extra callback arg, or within the BucketInfo returned by getBucketAndObject such as { bucket, object, raftSessionId })

I initially chose to add it to BucketInfo to reduce the footprint of change (we could retrieve the raft session ID from the bucket info without having to modify getBucketAttributes and getBucketAndObject callbacks.

But indeed, this doesn't fit with bucket metadata. Fixed.

lib/storage/metadata/MetadataWrapper.js

tests/unit/storage/metadata/MetadataWrapper.spec.js

lib/storage/metadata/MetadataWrapper.js

bert-e · 2025-10-24T07:44:48Z

Incorrect fix version

The Fix Version/s in issue ARSN-533 contains:

8.2.34
8.3.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.2.35
8.3.0

Please check the Fix Version/s of ARSN-533, or the target
branch of this pull request.

Pass raftSessionId in callbacks for getBucket and getBucketAndObject operations.

bert-e · 2025-10-24T07:56:52Z

Incorrect fix version

The Fix Version/s in issue ARSN-533 contains:

8.3.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.2.35
8.3.0

Please check the Fix Version/s of ARSN-533, or the target
branch of this pull request.

bert-e · 2025-10-24T07:57:47Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

dvasilas · 2025-10-24T07:58:48Z

/approve

bert-e · 2025-10-24T07:58:58Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/ARSN-533 into
development/8.2
w/8.3/improvement/ARSN-533 will be merged into development/8.3

The following branches will NOT be impacted:

development/6.4
development/7.10
development/7.4
development/7.70
development/8.1

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2025-10-24T08:08:25Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/8.2
✔️ development/8.3

The following branches have NOT changed:

development/6.4
development/7.10
development/7.4
development/7.70
development/8.1

Please check the status of the associated issue ARSN-533.

Goodbye dvasilas.

The following options are set: approve

dvasilas force-pushed the improvement/ARSN-533 branch 2 times, most recently from 0858d72 to fbd8ede Compare October 22, 2025 08:20

dvasilas requested a review from a team October 22, 2025 08:59

jonathan-gramain reviewed Oct 22, 2025

View reviewed changes

dvasilas force-pushed the improvement/ARSN-533 branch from fbd8ede to be4537c Compare October 23, 2025 09:14

dvasilas requested review from a team and jonathan-gramain October 23, 2025 13:25

dvasilas mentioned this pull request Oct 23, 2025

CLDSRV-769: Add raftSessionId to BucketInfo scality/cloudserver#5979

Merged

BourgoisMickael approved these changes Oct 23, 2025

View reviewed changes

lib/storage/metadata/MetadataWrapper.js Outdated Show resolved Hide resolved

tests/unit/storage/metadata/MetadataWrapper.spec.js Outdated Show resolved Hide resolved

nicolas2bert approved these changes Oct 23, 2025

View reviewed changes

jonathan-gramain approved these changes Oct 23, 2025

View reviewed changes

lib/storage/metadata/MetadataWrapper.js Outdated Show resolved Hide resolved

dvasilas force-pushed the improvement/ARSN-533 branch from d40b59e to eb2afa5 Compare October 24, 2025 07:45

dvasilas added 2 commits October 24, 2025 10:48

ARSN-533: Propagate raft session ID through metadata operations

184d37b

Pass raftSessionId in callbacks for getBucket and getBucketAndObject operations.

ARSN-533: Bump version

51640ec

dvasilas force-pushed the improvement/ARSN-533 branch from eb2afa5 to 51640ec Compare October 24, 2025 07:49

bert-e merged commit 51640ec into development/8.2 Oct 24, 2025
7 checks passed

bert-e deleted the improvement/ARSN-533 branch October 24, 2025 08:08

dvasilas mentioned this pull request Nov 6, 2025

CLDSRV-776: Fix batchDelete route to handle raftSessionId parameter from Arsenal scality/cloudserver#5993

Merged

ARSN-533: Get raft session ID from metadata on getBucketAttributes and getBucketAndObjectMD #2560

ARSN-533: Get raft session ID from metadata on getBucketAttributes and getBucketAndObjectMD #2560

Uh oh!

Conversation

dvasilas commented Oct 21, 2025

Uh oh!

bert-e commented Oct 21, 2025

Hello dvasilas,

Uh oh!

bert-e commented Oct 21, 2025

Incorrect fix version

Uh oh!

bert-e commented Oct 21, 2025

Request integration branches

Uh oh!

codecov bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jonathan-gramain Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

dvasilas Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bert-e commented Oct 24, 2025

Incorrect fix version

Uh oh!

bert-e commented Oct 24, 2025

Incorrect fix version

Uh oh!

bert-e commented Oct 24, 2025

Request integration branches

Uh oh!

dvasilas commented Oct 24, 2025

Uh oh!

bert-e commented Oct 24, 2025

Integration data created

Uh oh!

bert-e commented Oct 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Oct 22, 2025 •

edited

Loading