adding tests for externalclients and gcpservice #2579
+4,963
−3,384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we can no longer use the Service.defineService previously used in aws-sdk v2, we have to manually this commit aims to implement the GCP client using the new aws-sdk v3 architecture and migrate the existing code to use it. Please note that now both the setup and signing mechanisms had to be re-implemented in the GcpService file. Issue: ARSN-514
Issue: ARSN-514
In this commit several changes were done as aws-sdk v3 happens to be less permissive than v2 in terms of error handling and stream management. To ensure backward compatibility with existing functionalities adjustments were made, please refer to code comments for more details. Issue: ARSN-514
As the sdk now returns name instead of code for errors, we need to adapt the error handling accordingly. Issue: ARSN-514
Issue: ARSN-514
Issue: ARSN-514
A security issue was fixed using resolutions in package.json as the vulnerability is in a transient dependency. Issue: ARSN-514
This commit aims to add tests for the ExternalClients module and the GcpService module to ensure their proper functionality and reliability. The tests target the remaining not tested apis. The deleteIfExists method is also added to the DummyService to simulate deletion scenarios in the tests. Issue: ARSN-524
benzekrimaha
force-pushed
the
improvement/ARSN-524
branch
from
146c259 to
6166515
Compare
DarkIsDude
approved these changes
Dec 5, 2025
Comment on lines
+92
to
+97
| async deleteIfExists() { | ||
| if (this.key === 'externalBackendTestBucket/externalBackendMissingKey') { | ||
| return { succeeded: false }; | ||
| } | ||
| return { succeeded: true }; | ||
| } |
Contributor
There was a problem hiding this comment.
I don't know how you imagine your futur but you can do :
return { succeeded: this.key !== 'externalBackendTestBucket/externalBackendMissingKey' }
| function invalidDnsBucketNameHandler() { | ||
| return (req, res) => { | ||
| assert(req.headers.host, host); | ||
| assert(req.headers.host, host); |
| }); | ||
| }); | ||
|
|
||
| it('createMultipartUpload should reject missing parameters', done => { |
Contributor
There was a problem hiding this comment.
Suggested change
| it('createMultipartUpload should reject missing parameters', done => { | |
| it('createMultipartUpload should reject if parameters are missing', done => { |
benzekrimaha
force-pushed
the
improvement/ARSN-524
branch
from
82141f3 to
6166515
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## improvement/ARSN-514 #2579 +/- ##
============================================
============================================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benzekrimaha
force-pushed
the
improvement/ARSN-514
branch
2 times, most recently
from
ed14c60 to
b978085
Compare
benzekrimaha
force-pushed
the
improvement/ARSN-514
branch
2 times, most recently
from
e36f845 to
e66bc75
Compare
SylvainSenechal
force-pushed
the
improvement/ARSN-514
branch
2 times, most recently
from
6e00a70 to
00033b5
Compare
Contributor
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/improvement/ARSN-524 && \
git merge origin/development/8.3Resolve merge conflicts and commit git push origin HEAD:improvement/ARSN-524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: ARSN-524