Skip to content

Replace zenkoclient with cloudserver client#364

Merged
bert-e merged 1 commit into
development/1.17from
improvement/S3UTILS-206
Jan 27, 2026
Merged

Replace zenkoclient with cloudserver client#364
bert-e merged 1 commit into
development/1.17from
improvement/S3UTILS-206

Conversation

@SylvainSenechal
Copy link
Copy Markdown
Contributor

@SylvainSenechal SylvainSenechal commented Jan 15, 2026

ISSUE: S3UTILS-206

🫡 thank you for your service zenkoclient 🫡

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jan 15, 2026

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@SylvainSenechal SylvainSenechal force-pushed the improvement/S3UTILS-206 branch from 7ae5760 to 5054be5 Compare January 23, 2026 16:44
@SylvainSenechal SylvainSenechal changed the base branch from development/1.16 to development/1.17 January 23, 2026 16:46
@SylvainSenechal SylvainSenechal force-pushed the improvement/S3UTILS-206 branch 2 times, most recently from 027a88f to 8172406 Compare January 26, 2026 09:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.65%. Comparing base (8ff7ef7) to head (6e50e9a).
⚠️ Report is 1 commits behind head on development/1.17.

Files with missing lines Patch % Lines
Clients/CloudserverClient.js 0.00% 15 Missing ⚠️
autoRetryFailedCRR.js 0.00% 8 Missing ⚠️
stalled.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           development/1.17     #364      +/-   ##
====================================================
- Coverage             43.76%   43.65%   -0.12%     
====================================================
  Files                    84       84              
  Lines                  5961     5977      +16     
  Branches               1256     1257       +1     
====================================================
  Hits                   2609     2609              
- Misses                 3306     3322      +16     
  Partials                 46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SylvainSenechal SylvainSenechal requested review from a team, DarkIsDude and delthas January 26, 2026 10:01
@SylvainSenechal SylvainSenechal marked this pull request as ready for review January 26, 2026 10:01
@delthas delthas requested a review from Copilot January 26, 2026 11:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request replaces the zenkoclient dependency with cloudserverclient throughout the codebase. The migration updates the client instantiation pattern and removes the deprecated zenkoclient package from dependencies.

Changes:

  • Upgraded @scality/cloudserverclient from git reference v1.0.0 to published version ^1.0.3
  • Removed zenkoclient dependency and replaced all usages with CloudserverClient
  • Updated client initialization patterns in stalled.js and autoRetryFailedCRR.js to use simplified constructor signature
  • Added new methods (getLocationsStatus, listFailed, retryFailedObjects) to CloudserverClient wrapper class
  • Removed unused BackbeatClient import from cleanupNoncurrentVersions.js

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Updated cloudserverclient to published version ^1.0.3, removed zenkoclient dependency
yarn.lock Reflected dependency changes, removed zenkoclient and aws-sdk v2 entries
stalled.js Replaced ZenkoClient instantiation with CloudserverClient using simplified constructor
autoRetryFailedCRR.js Replaced ZenkoClient with CloudserverClient, updated response handling for getLocationsStatus, added null check for Versions array
cleanupNoncurrentVersions.js Removed unused BackbeatClient import
StalledRetry/StalledRequestHandler.js Wrapped JSON string in Buffer.from() for retryFailedObjects call
Clients/CloudserverClient.js Added three new methods: getLocationsStatus, listFailed, and retryFailedObjects

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Clients/CloudserverClient.js Outdated
Comment thread autoRetryFailedCRR.js Outdated
@delthas
Copy link
Copy Markdown

delthas commented Jan 26, 2026

(I just asked for a Copilot review, but feel free to resolve its comments if they are not relevant 🙂 )

@SylvainSenechal SylvainSenechal force-pushed the improvement/S3UTILS-206 branch from 8172406 to e71d0d7 Compare January 26, 2026 13:31
@scality scality deleted a comment from bert-e Jan 26, 2026
@scality scality deleted a comment from bert-e Jan 26, 2026
@scality scality deleted a comment from bert-e Jan 26, 2026
@SylvainSenechal SylvainSenechal force-pushed the improvement/S3UTILS-206 branch from e71d0d7 to 6e50e9a Compare January 26, 2026 13:38
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jan 26, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@scality scality deleted a comment from bert-e Jan 26, 2026
@SylvainSenechal
Copy link
Copy Markdown
Contributor Author

/create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jan 27, 2026

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge improvement/S3UTILS-206 into
    development/1.17
  • w/1/improvement/S3UTILS-206 will be merged into development/1

The following branches will NOT be impacted:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.16
  • development/1.4
  • development/1.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jan 27, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@SylvainSenechal
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jan 27, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.17

  • ✔️ development/1

The following branches have NOT changed:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.16
  • development/1.4
  • development/1.7

Please check the status of the associated issue S3UTILS-206.

Goodbye sylvainsenechal.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit 6e50e9a into development/1.17 Jan 27, 2026
12 of 14 checks passed
@bert-e bert-e deleted the improvement/S3UTILS-206 branch January 27, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants