Replace zenkoclient with cloudserver client#364
Conversation
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
7ae5760 to
5054be5
Compare
027a88f to
8172406
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development/1.17 #364 +/- ##
====================================================
- Coverage 43.76% 43.65% -0.12%
====================================================
Files 84 84
Lines 5961 5977 +16
Branches 1256 1257 +1
====================================================
Hits 2609 2609
- Misses 3306 3322 +16
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request replaces the zenkoclient dependency with cloudserverclient throughout the codebase. The migration updates the client instantiation pattern and removes the deprecated zenkoclient package from dependencies.
Changes:
- Upgraded
@scality/cloudserverclientfrom git reference v1.0.0 to published version ^1.0.3 - Removed
zenkoclientdependency and replaced all usages withCloudserverClient - Updated client initialization patterns in
stalled.jsandautoRetryFailedCRR.jsto use simplified constructor signature - Added new methods (
getLocationsStatus,listFailed,retryFailedObjects) toCloudserverClientwrapper class - Removed unused
BackbeatClientimport fromcleanupNoncurrentVersions.js
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated cloudserverclient to published version ^1.0.3, removed zenkoclient dependency |
| yarn.lock | Reflected dependency changes, removed zenkoclient and aws-sdk v2 entries |
| stalled.js | Replaced ZenkoClient instantiation with CloudserverClient using simplified constructor |
| autoRetryFailedCRR.js | Replaced ZenkoClient with CloudserverClient, updated response handling for getLocationsStatus, added null check for Versions array |
| cleanupNoncurrentVersions.js | Removed unused BackbeatClient import |
| StalledRetry/StalledRequestHandler.js | Wrapped JSON string in Buffer.from() for retryFailedObjects call |
| Clients/CloudserverClient.js | Added three new methods: getLocationsStatus, listFailed, and retryFailedObjects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
(I just asked for a Copilot review, but feel free to resolve its comments if they are not relevant 🙂 ) |
8172406 to
e71d0d7
Compare
e71d0d7 to
6e50e9a
Compare
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
|
/create_integration_branches |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue S3UTILS-206. Goodbye sylvainsenechal. The following options are set: approve, create_integration_branches |
ISSUE: S3UTILS-206
🫡 thank you for your service zenkoclient 🫡