Skip to content

fix: concurrent range requests return 500 (multi-threaded resume download broken) #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scanfing merged 4 commits into from
Apr 28, 2026
Merged

fix: concurrent range requests return 500 (multi-threaded resume download broken) #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3937944
fix: concurrent range request 500 errors (FileShare.Read, ContentLeng…
Copilot Apr 28, 2026
17b3dfc
fix: add path traversal guard in GetResponseContentTypeAndStream
Copilot Apr 28, 2026
f5567ee
fix: use safePath for FileStream and SubAccessCount to resolve CodeQL…
Copilot Apr 28, 2026
9d5ca6d
fix: wrap Path.GetFullPath in try-catch and remove sensitive path fro…
Copilot Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .nuget/nuget.exe
View file
Open in desktop
Binary file not shown.
46 changes: 34 additions & 12 deletions src/HttpFileServer/Handlers/HttpGetHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,28 +262,47 @@ protected async Task<Tuple<string, Stream, bool>> GetResponseContentTypeAndStrea
Stream stream = null;
var fileExist = false;

// Guard against path traversal: ensure resolved path stays within SourceDir
string safeRoot, safePath;
try
{
safeRoot = Path.GetFullPath(SourceDir);
safePath = Path.GetFullPath(path);
}
catch (Exception)
{
// Invalid path characters or other path resolution errors
return new Tuple<string, Stream, bool>(contentType, null, false);
}
if (!safePath.StartsWith(safeRoot + Path.DirectorySeparatorChar, StringComparison.OrdinalIgnoreCase) &&
!safePath.Equals(safeRoot, StringComparison.OrdinalIgnoreCase))
{
System.Diagnostics.Trace.TraceWarning($"Path traversal attempt blocked: resolved path outside SourceDir");
return new Tuple<string, Stream, bool>(contentType, null, false);
}

var data = _cacheSrv?.GetCache(path);
if (data is null)
{
if (File.Exists(path))
if (File.Exists(safePath))
{
await FileAccessHelper.AddAccessCount(path);
await FileAccessHelper.AddAccessCount(safePath);
fileExist = true;
stream = new FileStream(path, FileMode.Open, FileAccess.Read);
stream = new FileStream(safePath, FileMode.Open, FileAccess.Read, FileShare.Read);
contentType = "application/octet-stream";
}
else if (Directory.Exists(path))
else if (Directory.Exists(safePath))
{
var location = Path.GetFileName(path);
var location = Path.GetFileName(safePath);
var title = "HttpFileServer";
if (path != SourceDir)
if (safePath != SourceDir)
{
location = Path.GetFileName(SourceDir) + "\\" + path.Replace(SourceDir, "").Trim('\\');
title = Path.GetFileName(path.TrimEnd('\\')) + " -- HttpFileServer";
location = Path.GetFileName(SourceDir) + "\\" + safePath.Replace(SourceDir, "").Trim('\\');
title = Path.GetFileName(safePath.TrimEnd('\\')) + " -- HttpFileServer";
}
var content = HtmlExtension.GenerateHtmlContentForDir(SourceDir, path, path != SourceDir, EnableUpload, location, title, _debugResourceDir);
var content = HtmlExtension.GenerateHtmlContentForDir(SourceDir, safePath, safePath != SourceDir, EnableUpload, location, title, _debugResourceDir);
data = Encoding.UTF8.GetBytes(content);
_cacheSrv?.SaveCache(path, data);
_cacheSrv?.SaveCache(safePath, data);
stream = new MemoryStream(data);
}
}
Expand Down Expand Up @@ -489,6 +508,7 @@ protected async Task ResponseContentFull(string path, HttpListenerRequest reques
response.StatusCode = (int)HttpStatusCode.NotFound;
return;
}
response.AddHeader("Accept-Ranges", "bytes");
response.ContentLength64 = stream.Length;
try
{
Expand All @@ -504,7 +524,7 @@ protected async Task ResponseContentFull(string path, HttpListenerRequest reques
{
if (tp.Item3)
{
FileAccessHelper.SubAccessCount(path);
FileAccessHelper.SubAccessCount(Path.GetFullPath(path));
}
stream.Close();
}
Expand Down Expand Up @@ -556,9 +576,11 @@ protected async Task ResponseContentPartial(string path, HttpListenerRequest req
return;
}
response.AddHeader("Content-Range", $"bytes {range.Item1}-{range.Item2}/{stream.Length}");
response.AddHeader("Accept-Ranges", "bytes");
var buff = new byte[81920];
var rangeEnd = range.Item2 > range.Item1 ? range.Item2 : stream.Length - 1;
var bytesNeeds = rangeEnd - range.Item1 + 1;
response.ContentLength64 = bytesNeeds;
response.StatusCode = (int)HttpStatusCode.PartialContent;
try
{
Expand Down Expand Up @@ -586,7 +608,7 @@ protected async Task ResponseContentPartial(string path, HttpListenerRequest req
{
if (tp.Item3)
{
FileAccessHelper.SubAccessCount(path);
FileAccessHelper.SubAccessCount(Path.GetFullPath(path));
}
stream.Close();
}
Expand Down
2 changes: 1 addition & 1 deletion src/HttpFileServer/Services/FileAccessHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ static FileAccessHelper()

#region Properties

public static int LimitCount { get; set; } = 2;
public static int LimitCount { get; set; } = 32;

#endregion Properties

Expand Down