Fix WPF Error 23 on empty NavigateUri + MC3074 build error#15
Merged
Conversation
Agent-Logs-Url: https://github.com/scanfing/HttpFileServer/sessions/1c5beea7-1061-4359-b4e8-e4bc740a1757 Co-authored-by: scanfing <9262469+scanfing@users.noreply.github.com>
…check handles it correctly Agent-Logs-Url: https://github.com/scanfing/HttpFileServer/sessions/1c5beea7-1061-4359-b4e8-e4bc740a1757 Co-authored-by: scanfing <9262469+scanfing@users.noreply.github.com>
…rsal false positive Agent-Logs-Url: https://github.com/scanfing/HttpFileServer/sessions/2b4475a3-0fb0-4a17-871e-458442546e03 Co-authored-by: scanfing <9262469+scanfing@users.noreply.github.com>
…i bindings Agent-Logs-Url: https://github.com/scanfing/HttpFileServer/sessions/ac633601-d3b0-4dd7-aa71-cba1c3557ba8 Co-authored-by: scanfing <9262469+scanfing@users.noreply.github.com>
Agent-Logs-Url: https://github.com/scanfing/HttpFileServer/sessions/29030b53-2292-4902-89ac-a1fc27344f67 Co-authored-by: scanfing <9262469+scanfing@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
scanfing
April 28, 2026 12:56
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hyperlink.NavigateUriexpects aUri, butIPv4Text/IPv6Textstart asstring.Empty. WPF's built-in converter callsnew Uri(""), throwsUriFormatException, and surfaces as System.Windows.Data Error 23 on every launch before the server starts.Changes
Converters/StringToUriConverter.cs— newIValueConverterusingUri.TryCreate(..., UriKind.Absolute, ...), returningnullfor empty or invalid strings; whenNavigateUriisnullWPF skips conversion silently and won't fireRequestNavigateViews/ShellView.xaml— registerStringToUriConverterasstringToUriresource; apply it to bothHyperlink NavigateUribindingsHttpFileServer.csproj— add explicit<Compile Include="Converters\StringToUriConverter.cs" />(old-style project; omitting it caused MC3074 build error)