Conversation
Owner
Author
|
This also closes #10 . |
|
Thanks, I can confirm that these patches fix the two worst cases that I had (tested on Ubuntu 20.04 / gcc 9.3.0 and CentOS 7 / gcc 4.8.5). |
Owner
Author
|
Thanks for testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the triangle computation when
m1=p1andm2=m3=p2=0in real mass regime.We thank @JacekHoleczek for pointing out this issue.
Bug description
The following configuration:
generates the wrong output for the finite part:
Expected behaviour
This PR fixes the issue. The final output is:
@JacekHoleczek could you please test this branch and let me know if this fixes the issue you have reported?