Fix an off-by-one error in Tools::ddilog#24
Merged
Conversation
scarrazza
approved these changes
Jun 21, 2024
Owner
scarrazza
left a comment
scarrazza
left a comment
There was a problem hiding this comment.
Thank you for spotting this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop over coefficients
_Cstarts with indexi=_C.size(), which is out of bounds because the last element has indexi=_C.size()-1.This does not matter if the uninitialized
_C[_C.size()]happens to be zero, but I believe this is not guaranteed.