Merged
Conversation
Expands the x axis' lower bound to -1 and y axis' upper bound to 101 so that points lying directly at 0% divergence or 100% mAb identity are still plotted (see warning about removal of data outside limits in ?ggplot2::scale_continuous) and expands available selection area in interactive plot to match
Adds a --plotmethod to the get_island script, and code to plot_all, to support a method for binning points to plot instead of using KDE.
Owner
|
@ressy Thanks! Have you tested how changing the boundaries of the plot affects the behavior of gglocator? There's always been some wobble where the point placed doesn't seem to hit exactly where you clicked... |
Contributor
Author
|
Just judging by eye (and memory) I don't think changing the plot boundaries changed that behavior either way, though yeah, now that you mention it I think I've just subconsciously adjusted to that slight offset with the clicking... and I think that's still the same. (I had thought it might just be something odd about my remote X11 setup, but I guess not!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes two changes to the ID/DIV plotting:
That second one can be enabled by giving
--plotmethod binnedto the script, where--plotmethod originalis still the default since the other method does result in somewhat different-looking plots. This should fix #15 by making sure the points in that example are always visible.@scharch how's this look? Just let me know if any of this should be implemented differently.