This repository was archived by the owner on Feb 17, 2026. It is now read-only.
feat: close final 3 features -- gotestsum, branding, e2e fixes#11
Merged
schwichtgit merged 3 commits intomainfrom Feb 17, 2026
Merged
feat: close final 3 features -- gotestsum, branding, e2e fixes#11schwichtgit merged 3 commits intomainfrom
schwichtgit merged 3 commits intomainfrom
Conversation
- Replace go test with gotestsum --format testdox in all Taskfile targets - Add gotestsum to setup task and CI workflows - Add dorny/test-reporter to CI for JUnit XML display in PR checks - Move kahi_logo.svg to assets/ and update README.md reference - Fix flaky TestStdin_Attach by replacing StringReader with io.Pipe to avoid race between SSE connection setup and stdin write - Update spec TEST-003 test count from 70 to 68 (2 known skips) - Update spec TEST-004 with dorny/test-reporter and all-target scope - Mark e2e-test-infrastructure, test-output-formatting, project-branding as passing in feature_list.json (93/93 complete)
The dorny/test-reporter step was skipped because it referenced steps.filter.outputs.golang from the changes job, which is not accessible cross-job. The golang job already gates on the filter output at the job level, so if: always() is sufficient.
- All Taskfile test targets now produce JUnit XML (unit-results.xml, integration-results.xml, e2e-results.xml) - ci.yml renders "Unit Test Results" check via dorny/test-reporter - integration.yml renders "Integration Test Results" and "E2E Test Results" checks via dorny/test-reporter - Add *-results.xml to .gitignore - Update spec TEST-004 and feature_list.json to reflect 3 separate reporter checks as the desired outcome
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestStdin_Attachby replacingstrings.NewReaderwithio.Pipeto eliminate race between SSE connection setup and stdin write. Update spec test count from 70 to 68 (2 known skips:TestDaemon_DaemonizeandTestAuth_TCPWithCreds).gotestsum --format testdox --junitfile. CI renders 3 separatedorny/test-reporterchecks on PRs:ci.ymlfromunit-results.xml)integration.ymlfromintegration-results.xml)integration.ymlfrome2e-results.xml)kahi_logo.svgfrom repo root toassets/directory. Update README.md reference to.dorny/test-reporterstep condition fromsteps.filter.outputs.golang(cross-job, always undefined) toif: always().All 93/93 features now pass.
Test plan
task testpasses (579 tests, testdox format, producesunit-results.xml)task test-e2epasses (66 pass, 2 skip, producese2e-results.xml)TestStdin_Attachstable after pipe fixgo vet ./...cleanassets/kahi_logo.svg, not at repo rootdorny/test-reporterchecks configured (Unit, Integration, E2E)*-results.xmlin.gitignore