Skip to content

fix: increase timeout for discovery #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gilbert-sci merged 1 commit into from
Aug 5, 2025
Merged

fix: increase timeout for discovery #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion synapse/cli/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def setup_device_uri(args):
if not is_valid_ip(args.uri):
# User passed in a name
console = Console()
device_ip = find_device_by_name(args.uri, console)
device_ip = find_device_by_name(args.uri, console, False, 60)
if not device_ip:
return None
args.uri = device_ip
Expand Down
11 changes: 7 additions & 4 deletions synapse/utils/discover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,19 @@ def discover(timeout_sec=DISCOVERY_TIMEOUT_SEC):
return list(discover_iter(timeout_sec))


def find_device_by_name(name, console, include_rpc_port=False):
def find_device_by_name(
name,
console,
include_rpc_port=False,
discovery_timeout_sec=5,
):
"""Find a device by name using the discovery process."""
with console.status(
f"Searching for device with name {name}...", spinner="bouncingBall"
):
# We are broadcasting data every 1 second
socket_timeout_sec = 1
discovery_timeout_sec = 5
found_devices = []
devices = discover_iter(socket_timeout_sec, discovery_timeout_sec)
devices = discover_iter(1, discovery_timeout_sec)
for device in devices:
if device.name.lower() == name.lower():
if include_rpc_port:
Expand Down