Add text to encourage comments on blog post; invisible by default#700
Conversation
✅ Deploy Preview for scientific-python-hugo-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
I think this would be nice. Side note; the linkchecker plugin invites a lot of noise. I'd like to change that later on, as we've discussed previously. Do you think you'll change the visibility of the please-comment container using JS? Also, shouldn't we do this for the blog/single.html layout directly?
|
In the accompanying PR on the blog site, I show how to enable it using CSS |
|
Thanks! Hmm, no, CSS is indeed the best design. For some reason I thought https://github.com/scientific-python/blog.scientific-python.org/blob/a2e9beccc6d837d7bce1b89d97ec29cdd1e1cb33/layouts/partials/posts/comments.html was part of the theme and I am surprised it isn't (so my suggestion to put it in Is this PR ready for review/merging as is? I'm happy to approve if it works for you. |
|
For the theme, I think having giscus as the default commenting mechanism makes most sense. The setup we have for connecting to Discourse is very bespoke. |
|
I think this one's okay. Not perfect, but fine for now. |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Let's land this, then. Thanks @stefanv!
I am temporarily retracting my approval for now, as I did not mean to approve this but rather only comment – see above
|
I made the change you suggested, thanks @agriyakhetarpal |
|
(In general, btw, I am totally fine to have commits pushed to my branches, in case that helps streamline things.) |
a035d21 to
e5fd961
Compare
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Noted! Thanks! Approving now, let's test this out soon-ish.
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
e5fd961 to
decc6bc
Compare

No description provided.