feat: download scikit-build when building from source#114
Merged
Conversation
henryiii
commented
Sep 22, 2020
jcfr
reviewed
Oct 20, 2020
Contributor
jcfr
left a comment
jcfr
left a comment
There was a problem hiding this comment.
Thanks for the contribution 🙏
Could you also add an entry to CHANGES.md
Contributor
Author
|
I'm not sure where I should add the change, there doesn't seem to be CHANGES.md, and HISTORY.rst doesn't seem to have anything yet, should it go there? |
henryiii
commented
Nov 23, 2020
henryiii
force-pushed
the
feat/pyproject.toml
branch
from
13d29aa to
260b98d
Compare
jcfr
force-pushed
the
feat/pyproject.toml
branch
from
260b98d to
71f1e34
Compare
Specify build_meta backend because the default "setuptools.__legacy__" one often has issues. PyPA-build for example tends to break with the __legacy__ behavior, it also does not catch bugs with the SDist, while the build_meta behavior does See https://setuptools.readthedocs.io/en/latest/build_meta.html
jcfr
force-pushed
the
feat/pyproject.toml
branch
from
71f1e34 to
a91c5bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will cause installing from source to succeed or provide a much better error with pip 10+.
See scikit-build/ninja-python-distributions#26