ci/travis: Attempt to fix pypi upload of arm64 wheel#121
Merged
Conversation
jcfr
changed the title
Merged
* Remove setting of PYTHON_VERSION environment variable. This variable had non effect and was set to an incorrect value. At the time of this commit python version 3.8.2 was the default. * Explicitly install twine when operating system is Linux * Update deploy-release step to update PATH instead of explicitly referencing the path to twine executable, this will allow the deployment to work on both macOS and Linux * Update after_success step to display version of twine and catch potential issue with deploy-release step.
jcfr
force-pushed
the
fix-travis-arm64-release-deployment-step
branch
from
cb132bf to
cdf2f46
Compare
jcfr
changed the title
Contributor
|
Looks to me like this should to it. Thanks for fixing this! |
Contributor
|
I don't think I can give an official review, since I'm not a member of this project, but this is my unofficial 👍. |
Contributor
Author
|
Thanks @AWSjswinney
In the meantime, I just invited you to the scikit-build organization. |
Contributor
Author
|
Twine is available ✔️ I will then publish tag
|
|
Looks like the wheel works on an AWS c6g (Graviton2). Thanks! |
Contributor
Author
|
@PhilMiller Thanks for testing 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Merge only after revertingbranchassociated withdeploy-masterfromfix-travis-arm64-release-deployment-steptomasterRemove setting of PYTHON_VERSION environment variable. This variable
had non effect and was set to an incorrect value. At the time of this
commit python version 3.8.2 was the default.
Explicitly install twine when operating system is Linux
Update deploy-release step to update PATH instead of explicitly referencing
the path to twine executable, this will allow the deployment to work on
both macOS and Linux
Update deploy-master step to display version of twine and catch potential
issue with deploy-release step.