fix: building from sdist fails#136
Merged
Merged
Conversation
mayeut
force-pushed
the
test-source-distribution
branch
4 times, most recently
from
33e821a to
09b70eb
Compare
mayeut
force-pushed
the
test-source-distribution
branch
from
a96f066 to
c5500a5
Compare
Contributor
|
Let's go with this PR first, then merge the CMake update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same issues as were found in Ninja distribution scikit-build/ninja-python-distributions#43 when building from sdist:
2.1 The "import issue" affects all builds from sdist
2.2 The ill-specified version returned by versioneer only impacts ci as it would be impossible to upload the sdist to PyPI