Skip to content

feat: use scikit-build-core#247

Merged
mayeut merged 11 commits into
masterfrom
henryiii/feat/skbc
May 28, 2024
Merged

feat: use scikit-build-core#247
mayeut merged 11 commits into
masterfrom
henryiii/feat/skbc

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

Moving to scikit-build-core.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/feat/skbc branch from 2a99473 to 1f805f0 Compare May 20, 2024 05:58
@henryiii henryiii force-pushed the henryiii/feat/skbc branch 4 times, most recently from 92d6a16 to cf7b71d Compare May 20, 2024 10:39
@henryiii henryiii force-pushed the henryiii/feat/skbc branch from cf7b71d to 674c3f6 Compare May 20, 2024 10:47
Comment thread pyproject.toml
henryiii and others added 2 commits May 21, 2024 00:14
Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/feat/skbc branch from 535ad64 to 9d374fe Compare May 21, 2024 04:52
@henryiii henryiii marked this pull request as ready for review May 21, 2024 05:01
@henryiii
Copy link
Copy Markdown
Contributor Author

I'd like to make a follow-up dropping 2.7. Better if an SDist build is made, and better for dropping manylinux1. We could keep manylinux1 if we forced only binaries for cmake, I think, as it would then get the last manylinux1 cmake. But better just do update, I think.

@mayeut
Copy link
Copy Markdown
Contributor

mayeut commented May 27, 2024

We could keep manylinux1 if we forced only binaries for cmake, I think, as it would then get the last manylinux1 cmake. But better just do update, I think.

Should we build on manylinux2010 (as we do with CMake) ?
Maybe it's not worth it given the low number of downloads for manylinux 2010 (glibc 2.12) vs 2014 (glibc 2.17) for ninja the last 30 days (I removed some rows in there):

libc_version cum_percent download_count
2.35 32.88 % 2,359,423
2.34 33.79 % 74,313
2.31 72.24 % 3,154,519
2.28 76.20 % 324,935
2.27 80.20 % 327,986
2.26 96.37 % 1,326,990
2.24 96.39 % 1,972
2.23 96.61 % 17,466
2.17 99.95 % 271,337
2.12 100.00 % 4,214
2.9 100.00 % 52
2.5 100.00 % 41
Total 8,206,430

@henryiii
Copy link
Copy Markdown
Contributor Author

henryiii commented May 28, 2024

Not "worth it", but fine to be consistent.

Comment thread pyproject.toml
@henryiii
Copy link
Copy Markdown
Contributor Author

(Also when we drop 3.6 and below, that distribution may change)

@mayeut mayeut merged commit f3b4a78 into master May 28, 2024
@mayeut mayeut deleted the henryiii/feat/skbc branch May 28, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants