feat: Fail early if Ninja sources are missing#303
Merged
henryiii merged 1 commit intoJun 20, 2025
Conversation
Add an explicit check in the top-level `CMakeLists.txt` to verify that the `ninja-upstream` source directory is present. This helps catch configuration issues early, especially in environments where the source was cloned without initializing submodules. If the directory is missing and the project is under Git, the error suggests initializing submodules. Otherwise, it indicates an invalid source distribution.
jcfr
force-pushed
the
check-ninja-sources-are-available
branch
from
c30e248 to
d234744
Compare
mayeut
approved these changes
Jun 20, 2025
henryiii
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an explicit check in the top-level
CMakeLists.txtto verify that theninja-upstreamsource directory is present. This helps catch configuration issues early, especially in environments where the source was cloned without initializing sub-modules.If the directory is missing and the project is under Git, the error suggests initializing sub-modules. Otherwise, it indicates an invalid source distribution.