chore: use scikit-build 0.12#70
Conversation
henryiii
force-pushed
the
henryiii/chore/skbuildrc
branch
from
926736b to
3a14afb
Compare
| "setuptools>=42", | ||
| "wheel", | ||
| "scikit-build @ git+https://github.com/scikit-build/scikit-build.git@739238cfdc7224e02651f94b41f2aea1fd84b519", | ||
| ] |
There was a problem hiding this comment.
May also be worth updating https://github.com/scikit-build/ninja-python-distributions/blob/master/docs/make_a_release.rst to reference this commit. It could be useful to create future pre-release.
There was a problem hiding this comment.
This is only temporary - once the release is out, we'll update this to Oh, I see what you mean. Yes, that would be very useful to mention, I have to look this syntax up every single time I use it. Ideally in the future, though, we should probably make a "beta" or "RC" release on pypi, then have a job that can run with dev releases enabled, maybe even automatically (will be looking through the resources you sent).scikit-build >= 0.12
| - os: ubuntu-20.04 | ||
| arch: "s390x" | ||
| - os: windows-2016 | ||
| - os: windows-2019 |
There was a problem hiding this comment.
This is the one surprise, by the way. It works fine with windows-2019, but finds GCC with windows-2016. I don't think any of the other things we've tried have this problem, and we test on windows-2016, but it might be worth further investigation.
|
|
||
| [tool.cibuildwheel.macos.environment] | ||
| MACOSX_DEPLOYMENT_TARGET = "10.9" | ||
| CMAKE_OSX_ARCHITECTURES = "arm64;x86_64" |
There was a problem hiding this comment.
This is no longer required (but not harmful)
| match = re.match(r"^.*-macosx_(\d+)_(\d+)_x86_64\.whl$", file.name) | ||
| assert match is not None | ||
| match = re.match(r"^.*-macosx_(\d+)_(\d+)_.*\.whl$", file.name) | ||
| assert match is not None, f"Couldn't match on {file.name}" |
There was a problem hiding this comment.
The wheels used to be misnamed (scikit-build didn't understand universal naming), and now they are correctly tagged, so this had to be modified to pick up the correct name.
henryiii
force-pushed
the
henryiii/chore/skbuildrc
branch
from
3a14afb to
1ef50b1
Compare
henryiii
changed the title
|
💯 Thanks for taking the time to work on this 🙏 |
2 participants
No description provided.