chore: repo review updates#408
Merged
Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
=======================================
Coverage 83.21% 83.21%
=======================================
Files 96 96
Lines 11429 11429
=======================================
Hits 9511 9511
Misses 1918 1918 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 22, 2023
Saransh-cpp
approved these changes
Dec 23, 2023
Member
Saransh-cpp
left a comment
There was a problem hiding this comment.
Thanks, @henryiii! Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran repo-review (below) and fixed most of the issues. The
warn_unreachableone I think should probably check for existence, not the True setting.See scientific-python/cookie#348 for the grouping update.
Repo-review:
General
hatchling.buildPyProject
GitHub Actions
Projects should group their updates to avoid extra PRs and stay in sync. This is now supported by dependabot since June 2023.
Pre-commit
MyPy
Must not have
show_error_codes. Usehide_error_codesinstead (since MyPy v0.990).Ruff
extend-ignoredeprecated, useignoreinstead (identical)extend-ignoreshould be set aslint.extend-ignoreinsteadisortshould be set aslint.isortinsteadper-file-ignoresshould be set aslint.per-file-ignoresinsteadselectshould be set aslint.selectinsteadtyping-modulesshould be set aslint.typing-modulesinsteadunfixableshould be set aslint.unfixableinsteadDocumentation
Validate-PyProject
Checks
[build-system],[project],[tool.repo-review],[tool.setuptools]